fix(universal-router-sdk): bump v4-sdk and router-sdk (priceImpact calc fix) #478
Conversation
🤖 Claude Code Review
SummaryRoutine dependency bump in
Based on commit history, these updates include a fix for price impact calculations in v4-sdk. Analysis
No issues found. 💡 Want a fresh review? Add a comment containing |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
github-actions
bot
dismissed
their stale review
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
…/github.com/Uniswap/sdks into xrsv/bump-universal-router-sdk-v4sdk-1.25.1
github-actions
bot
dismissed
their stale review
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
github-actions
bot
dismissed
their stale review
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (01/07/26)3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
PR Scope
related PRs
#476
#477
Description
[Summary of the change, motivation, and context]
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]
✨ Claude-Generated Content
PR Scope
Related PRs:
Description
Bumps
@uniswap/v4-sdkand@uniswap/router-sdkdependencies in universal-router-sdk to pick up the price impact calculation fix from PR #476.Changes
@uniswap/router-sdkversion insdks/universal-router-sdk/package.jsonfrom^2.3.1to^2.3.2@uniswap/v4-sdkversion from^1.25.0to^1.25.1yarn.lockto reflect the new dependency versionsHow Has This Been Tested?
Will be tested in routing pipeline.
Are there any breaking changes?
No