chore(universal-router-sdk): add mock pools and test for V4 split routes#513
Draft
chore(universal-router-sdk): add mock pools and test for V4 split routes#513
Conversation
dianakocsis
reviewed
Feb 11, 2026
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):will trigger a patch versionchore(<type>):will not trigger any release and should be used for internal repo changes<type>(public):will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):will trigger a minor versionfeat(breaking):will trigger a major version for a breaking changeDescription
[Summary of the change, motivation, and context]
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]
✨ Claude-Generated Content
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):will trigger a patch versionchore(<type>):will not trigger any release and should be used for internal repo changes<type>(public):will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):will trigger a minor versionfeat(breaking):will trigger a major version for a breaking changeDescription
Adds test infrastructure for V4 split route calldata encoding in universal-router-sdk to support guidestar routes testing. This includes new mock tokens, mock V4 pools, and a test case verifying that split routes across multiple V4 pools encode correctly.
Changes
USDTandUNItoken definitions totest/utils/uniswapData.tsETH_USDT_V4,USDC_USDT_V4inuniswapTrades.test.tsencodes a split exactInput with 2 routes v4 USDC -> USDT, v4 USDC -> ETH -> USDTparseUnitsimport inuniswapTrades.test.ts@uniswap/router-sdkdependency to local tarballtmp/router-sdk-guidestar-routes-1.tgzfor testingHow Has This Been Tested?
Unit tests - the new test case validates split V4 route calldata encoding for USDC → USDT (single hop) and USDC → ETH → USDT (multi-hop) routes.
Are there any breaking changes?
No - test-only changes with a local dependency for development/testing purposes.
(Optional) Feedback Focus
This PR uses a local router-sdk tarball with modified behavior for pool duplication validation. Review whether this approach is appropriate for testing guidestar routes.
(Optional) Follow Ups