Skip to content

Fix parameter names #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeffishjeff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix parameter names #875

jeffishjeff wants to merge 2 commits into from

Conversation

@jeffishjeff
Copy link
Contributor

@jeffishjeff jeffishjeff commented Sep 9, 2024

Description of changes

  • Change the first parameter in Pool.donate() from state to self
  • Change the last parameter in StateLibrary.getTickBitmap() from tick to wordPos
  • Update the doc on TickBitmap.nextInitializedTickWithinOneWord(), as lesser / larger tick occupies lower(right) / upper(left) bit position in a word

@jeffishjeff jeffishjeff changed the title [suggestion] change variable names Fix parameter names Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Dustin4444 Dustin4444 Dustin4444 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffishjeff @Dustin4444