Skip to content

Fix amount0 and amount1 calculation with improved price range checks #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nigeldelviero wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix amount0 and amount1 calculation with improved price range checks #955

nigeldelviero wants to merge 4 commits into from

Conversation

@nigeldelviero
Copy link

@nigeldelviero nigeldelviero commented Feb 26, 2025

Related Issue

#954

Description of changes

  1. Fixed Calculation Logic in getMaxAmountInForPool:
  • Ensured correct order of sqrtPriceX96 values by adding conditional checks.
  • Added validation to verify that the current price is within the tick range.
  • Improved handling of edge cases such as price being exactly at boundaries.
  1. Enhanced Error Handling:
  • Added require statements to check if the price is within the acceptable range.
  • Proper error messages for out-of-range prices.

@nigeldelviero nigeldelviero requested a review from a team as a code owner February 26, 2025 07:37
louisbrown0212
louisbrown0212 reviewed Mar 5, 2025
View reviewed changes
louisbrown0212
louisbrown0212 reviewed Mar 5, 2025
View reviewed changes
louisbrown0212
louisbrown0212 reviewed Mar 5, 2025
View reviewed changes
ghost
ghost reviewed Mar 5, 2025
View reviewed changes
@nigeldelviero nigeldelviero requested review from a user and louisbrown0212 March 5, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louisbrown0212 louisbrown0212 Awaiting requested review from louisbrown0212

1 more reviewer
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nigeldelviero @louisbrown0212