Additional modifyLiquiditiesWithoutUnlock Tests#274
Open
saucepoint wants to merge 16 commits intomainfrom
Open
Additional modifyLiquiditiesWithoutUnlock Tests#274saucepoint wants to merge 16 commits intomainfrom
saucepoint wants to merge 16 commits intomainfrom
Conversation
snreynolds
reviewed
Aug 19, 2024
| // subscriber did not modify liquidity | ||
| assertEq(lpm.ownerOf(tokenId), address(this)); // owner still owns the position | ||
| assertEq(lpm.nextTokenId(), tokenId + 1); // no new token minted | ||
| assertEq(lpm.getPositionLiquidity(tokenId, config), 100e18); // liquidity unchanged |
Contributor
There was a problem hiding this comment.
assert subscriber is addr 0 and hasSubscriber is false?
| } | ||
|
|
||
| /// @dev subscribers cannot re-enter posm on-unsubscribe since PM is not unlocked | ||
| function test_fuzz_subscriber_unsubscribe_reenter_revert(uint256 seed) public { |
snreynolds
reviewed
Aug 19, 2024
| } | ||
| } | ||
|
|
||
| function notifyModifyLiquidity(uint256, PositionConfig memory, int256) external onlyByPosm { |
snreynolds
reviewed
Jan 17, 2025
Comment on lines
+291
to
+297
| abi.encodeWithSelector( | ||
| CustomRevert.WrappedError.selector, | ||
| address(hookModifyLiquidities), | ||
| IHooks.beforeRemoveLiquidity.selector, | ||
| abi.encodeWithSelector(ReentrancyLock.ContractLocked.selector), | ||
| abi.encodeWithSelector(Hooks.HookCallFailed.selector) | ||
| ) |
Contributor
There was a problem hiding this comment.
lol this is the craziest revert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Some tasks from #265
Description of changes
A new helper function
getFuzzySingleEncodedwhich randomly returns an encoded call for a single operation -- mint, increase, decrease, and burn.