Skip to content

add raw swap to enable providing sqrt price limit to router#474

Open
johnny-emp wants to merge 1 commit intoUniswap:mainfrom
johnny-emp:feat/add_sqrt_price_limit
Open

add raw swap to enable providing sqrt price limit to router#474
johnny-emp wants to merge 1 commit intoUniswap:mainfrom
johnny-emp:feat/add_sqrt_price_limit

Conversation

@johnny-emp
Copy link

Related Issue

Which issue does this pull request resolve?
#473

Description of changes

I add an additional action to the router, where you can provide the SwapParams directly. I did not do the unchecked serialization, but I wanted to see if there was a strong reason for not including this in the V4Router

@eversoluna
Copy link

Great suggestion! Why this PR isn't reviewed yet?

@johnny-emp
Copy link
Author

johnny-emp commented Jan 20, 2026

not sure, i don't think they actively respond to communicate PRs. i ended up implementing my own router to expose this, as swapping up to a fixed price is fairly useful when working with more volatile pairs. Looking back at this, it feels very reasonable and so I do wonder why there was never even a single comment from the team...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants