add raw swap to enable providing sqrt price limit to router#474
Open
johnny-emp wants to merge 1 commit intoUniswap:mainfrom
Open
add raw swap to enable providing sqrt price limit to router#474johnny-emp wants to merge 1 commit intoUniswap:mainfrom
johnny-emp wants to merge 1 commit intoUniswap:mainfrom
Conversation
|
Great suggestion! Why this PR isn't reviewed yet? |
Author
|
not sure, i don't think they actively respond to communicate PRs. i ended up implementing my own router to expose this, as swapping up to a fixed price is fairly useful when working with more volatile pairs. Looking back at this, it feels very reasonable and so I do wonder why there was never even a single comment from the team... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
#473
Description of changes
I add an additional action to the router, where you can provide the SwapParams directly. I did not do the unchecked serialization, but I wanted to see if there was a strong reason for not including this in the V4Router