Conversation
Unfixable due to the lack of support for typeof operator
There was a problem hiding this comment.
Pull Request Overview
This PR implements proper handling of JavaScript's loose equality operator (==) for null and undefined values, ensuring that null == undefined evaluates to true while maintaining correct behavior for other object comparisons.
- Adds comprehensive test coverage for null/undefined equality scenarios
- Refactors the
TsBinaryOperator.Eq::onRefmethod to correctly handle the special case wherenull == undefined - Updates existing equality resolution logic to use dedicated helper methods
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| usvm-ts/src/test/resources/samples/operators/Equality.ts | Adds test cases for null/undefined equality comparisons |
| usvm-ts/src/test/resources/samples/lang/Undefined.ts | Adds test method for checking undefined or null values |
| usvm-ts/src/test/resources/samples/lang/Null.ts | Adds test method for checking null or undefined values |
| usvm-ts/src/test/kotlin/org/usvm/samples/operators/Equality.kt | Adds Kotlin test cases for null/undefined equality scenarios |
| usvm-ts/src/test/kotlin/org/usvm/samples/lang/Undefined.kt | Adds test for undefined or null value detection |
| usvm-ts/src/test/kotlin/org/usvm/samples/lang/Null.kt | Adds test for null or undefined value detection and fixes import |
| usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt | Implements proper null/undefined equality logic and refactors equality resolution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CaelmBleidd
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
TsBinaryOperator.Eq::onReffor two heap refs which can representnullorundefinedJS values, which are actually loosely equal (null == undefined, but notnull === undefined), despite having different addresses. Other objects are compared via refs in JS, which is correctly translated tomkHeapRefEq.