Refactor native token transfers to use deposited transactions instead of withdrawals #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsuharnikov
requested changes
Jun 5, 2025
vladimirlogachev
force-pushed
the
native-token-transfers-deposits-2
branch
from
9e79ca8 to
621c6a1
Compare
vsuharnikov
reviewed
Jun 20, 2025
vsuharnikov
reviewed
Jun 20, 2025
consensus-client-it/src/test/scala/units/C2ENativeTokenTransfersViaDepositsTestSuite.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/MultipleTransfersViaDepositsTestSuite.scala
Outdated
Show resolved
Hide resolved
vladimirlogachev
force-pushed
the
native-token-transfers-deposits-2
branch
from
59eb7d5 to
701551f
Compare
goodmai
reviewed
Jul 7, 2025
|
|
||
| import com.wavesplatform.transaction.TxHelpers | ||
| import com.wavesplatform.state.IntegerDataEntry | ||
| import org.web3j.crypto.Credentials |
Contributor
Author
There was a problem hiding this comment.
Thank you, fixed
goodmai
reviewed
Jul 7, 2025
| val e2cWavesTxn = standardBridge.sendBridgeErc20(elSender, WWavesAddress, clRecipient.toAddress, wavesE2CAmount, nextNonce) | ||
|
|
||
| chainContract.waitForEpoch(waves1.api.height() + 1) // Bypass rollbacks | ||
| val e2cReceipts = List(e2cIssuedTxn, e2cIssuedTxn, e2cWavesTxn).map { txn => |
Contributor
Author
There was a problem hiding this comment.
Thank you, fixed
goodmai
approved these changes
Jul 7, 2025
vladimirlogachev
force-pushed
the
native-token-transfers-deposits-2
branch
from
0a2b9fb to
ab9939f
Compare
goodmai
approved these changes
Jul 8, 2025
goodmai
approved these changes
Jul 16, 2025
vsuharnikov
requested changes
Oct 16, 2025
consensus-client-it/src/test/scala/units/BlockValidationTestSuite.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/docker/WavesNodeContainer.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/TestNetworkClient.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/TestNetworkClient.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/docker/WavesNodeContainer.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/docker/WavesNodeContainer.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/docker/WavesNodeContainer.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Vyatcheslav Suharnikov <[email protected]>
…iner.scala Co-authored-by: Vyatcheslav Suharnikov <[email protected]>
…iner.scala Co-authored-by: Vyatcheslav Suharnikov <[email protected]>
…iner.scala Co-authored-by: Vyatcheslav Suharnikov <[email protected]>
…iner.scala Co-authored-by: Vyatcheslav Suharnikov <[email protected]>
Co-authored-by: Vyatcheslav Suharnikov <[email protected]>
vsuharnikov
approved these changes
Oct 17, 2025
consensus-client-it/src/test/scala/units/BaseBlockValidationSuite.scala
Outdated
Show resolved
Hide resolved
consensus-client-it/src/test/scala/units/BaseBlockValidationSuite.scala
Outdated
Show resolved
Hide resolved
phearnot
approved these changes
Oct 21, 2025
| val (nativeTransfers, assetTransfers) = transfers.partitionMap { | ||
| case x: ContractTransfer.Native => x.asLeft | ||
| case x: ContractTransfer.Asset => x.asRight | ||
| val nativeTransfersViaWithdrawals = transfers.flatMap { |
Contributor
There was a problem hiding this comment.
Suggested change
| val nativeTransfersViaWithdrawals = transfers.flatMap { | |
| val nativeTransfersViaWithdrawals = transfers.collect { | |
| case x: ContractTransfer.NativeViaWithdrawal => x | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalelocal-network, because it tends to grow again and again