Fixed "System.IndexOutOfRangeException: Index -1" in HDRP when zooming out in the scene view

Fixed an out of range exception in HDRP when reaching the max amount of shadows on screen.
This happens when reaching the maximum number of shadows on screen because the request for room in the atlas would then fail and return -1 which was not handled well later down the line.

Author: vincent-breysse

Packages/com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDShadowRequestUpdateJob.cs

@@ -142,6 +142,9 @@ public void Execute()
 
                     for (int index = 0; index < shadowIndicesAndVisibleLightData.splitCount; index++)
                     {
+                        if (!shadowIndicesAndVisibleLightData.isSplitValidMask[(uint)index])
+                            continue;
+
                         bool needToUpdateCachedContent = needCacheUpdateMask[(uint)index];
                         HDShadowRequestHandle indexHandle = shadowRequestSetHandle[index];
                         int shadowRequestIndex = requestIndicesStorage[indexHandle.storageIndexForRequestIndex];
@@ -190,6 +193,9 @@ public void Execute()
 
                     for (int index = 0; index < shadowIndicesAndVisibleLightData.splitCount; index++)
                     {
+                        if (!shadowIndicesAndVisibleLightData.isSplitValidMask[(uint)index])
+                            continue;
+
                         HDShadowRequestHandle indexHandle = shadowRequestSetHandle[index];
                         int shadowRequestIndex = requestIndicesStorage[indexHandle.storageIndexForRequestIndex];
                         ref HDShadowResolutionRequest resolutionRequest = ref shadowManager.shadowResolutionRequestStorage.ElementAt(shadowRequestIndex);
@@ -557,6 +563,9 @@ public void UpdateNonDirectionalCachedRequests(LightType lightType,
 
                 for (int index = 0; index < shadowIndicesAndVisibleLightData.splitCount; index++)
                 {
+                    if (!shadowIndicesAndVisibleLightData.isSplitValidMask[(uint)index])
+                        continue;
+
                     HDShadowRequestHandle indexHandle = shadowRequestSetHandle[index];
                     int shadowRequestIndex = requestIndicesStorage[indexHandle.storageIndexForRequestIndex];
                     ref HDShadowResolutionRequest resolutionRequest = ref shadowManager.shadowResolutionRequestStorage.ElementAt(shadowRequestIndex);
@@ -617,6 +626,9 @@ public void UpdateNonDirectionalDynamicRequests(LightType lightType,
 
                 for (int index = 0; index < shadowIndicesAndVisibleLightData.splitCount; index++)
                 {
+                    if (!shadowIndicesAndVisibleLightData.isSplitValidMask[(uint)index])
+                        continue;
+
                     HDShadowRequestHandle indexHandle = shadowRequestSetHandle[index];
                     int shadowRequestIndex = requestIndicesStorage[indexHandle.storageIndexForRequestIndex];
                     ref HDShadowResolutionRequest resolutionRequest = ref shadowManager.shadowResolutionRequestStorage.ElementAt(shadowRequestIndex);