Skip to content

Commit 6b57d04

Browse files
sindharta-tanuwijayaEvergreen
authored andcommitted
ShaderGraph: remove duplicate LIGHTMAP_ON and DIRLIGHTMAP_COMBINED variants for builtin-deferred
Unnecessary duplicate variants may be created due to the simultaneous usage of - `multi_compile_prepassfinal` - `LIGHTMAP_ON` and `DIRLIGHTMAP_COMBINED` in different lines. for deferred mode in built-in RP. This PR removes the usage of `LIGHTMAP_ON` and `DIRLIGHTMAP_COMBINED` to prevent the creation of these duplicate variants. [POI-828 [Shader System] Shader Variant Management](https://jira.unity3d.com/browse/POI-828)
1 parent 62ad5f8 commit 6b57d04

File tree

1 file changed

+0
-2
lines changed
  • Packages/com.unity.shadergraph/Editor/Generation/Targets/BuiltIn/Editor/ShaderGraph/Targets

1 file changed

+0
-2
lines changed

Packages/com.unity.shadergraph/Editor/Generation/Targets/BuiltIn/Editor/ShaderGraph/Targets/BuiltInLitSubTarget.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,8 +572,6 @@ static class LitKeywords
572572

573573
public static readonly KeywordCollection Deferred = new KeywordCollection
574574
{
575-
{ CoreKeywordDescriptors.Lightmap },
576-
{ CoreKeywordDescriptors.DirectionalLightmapCombined },
577575
{ CoreKeywordDescriptors.MainLightShadows },
578576
{ CoreKeywordDescriptors.ShadowsSoft },
579577
{ CoreKeywordDescriptors.LightmapShadowMixing },

0 commit comments

Comments
 (0)