[VFX] Some UI can overflow the bounds

Jira: UUM-70602
Steps to reproduce:
1. Create Random Selector Weighted node
2. Select it
3. In the Inspector, click Clamp Weight
4. Click Clamp Weight again

Actual results: The input fields have overflowed their container
Expected results: UI elements stay in their container upon adjusting parameters

Tested on (OS): repro with other input fields, labels too, i.e Input fields, labels that come from ShaderGraph

![](https://jira.unity3d.com/secure/attachment/1436950/Screenshot%202024-04-24%20at%2015.09.40.png)

Author: julienamsellem

Packages/com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXEditableDataAnchor.cs

@@ -114,7 +114,13 @@ void BuildProperty()
             {
                 Remove(m_PropertyRM);
             }
-            m_PropertyRM = PropertyRM.Create(controller, VFXNodeUI.DefaultLabelWidth);
+
+            var labelWidth = VFXNodeUI.DefaultLabelWidth;
+            if (node != null)
+            {
+                node.GetWidths(out labelWidth, out _);
+            }
+            m_PropertyRM = PropertyRM.Create(controller, labelWidth);
             if (m_PropertyRM != null)
             {
                 Add(m_PropertyRM);

Packages/com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXNodeUI.cs

@@ -172,10 +172,9 @@ public virtual void OnControllerChanged(ref ControllerChangedEvent e)
 
         protected virtual bool HasPosition() => true;
 
-        private bool SyncSettings()
+        private void SyncSettings()
         {
             Profiler.BeginSample("VFXNodeUI.SyncSettings");
-            var hasChanged = false;
             var settings = controller.settings;
             var graphSettings = controller.model.GetSettings(false, VFXSettingAttribute.VisibleFlags.InGraph).ToArray();
 
@@ -186,7 +185,6 @@ private bool SyncSettings()
                 {
                     propertyRM.RemoveFromHierarchy();
                     m_Settings.Remove(propertyRM);
-                    hasChanged = true;
                 }
             }
 
@@ -199,7 +197,6 @@ private bool SyncSettings()
                     var setting = settings.Single(x => string.Compare(x.name, vfxSetting.field.Name, StringComparison.OrdinalIgnoreCase) == 0);
                     var propertyRM = AddSetting(setting);
                     settingsContainer.Insert(i, propertyRM);
-                    hasChanged = true;
                 }
             }
 
@@ -224,20 +221,17 @@ private bool SyncSettings()
             }
 
             Profiler.EndSample();
-            return hasChanged;
         }
 
-        bool SyncAnchors()
+        void SyncAnchors()
         {
             Profiler.BeginSample("VFXNodeUI.SyncAnchors");
-            var hasResync = SyncAnchors(controller.outputPorts, outputContainer, false);
-            hasResync |= SyncAnchors(controller.inputPorts, inputContainer, controller.HasActivationAnchor);
+            SyncAnchors(controller.outputPorts, outputContainer, false);
+            SyncAnchors(controller.inputPorts, inputContainer, controller.HasActivationAnchor);
             Profiler.EndSample();
-
-            return hasResync;
         }
 
-        bool SyncAnchors(ReadOnlyCollection<VFXDataAnchorController> ports, VisualElement container, bool hasActivationPort)
+        void SyncAnchors(ReadOnlyCollection<VFXDataAnchorController> ports, VisualElement container, bool hasActivationPort)
         {
             // Check whether resync is needed
             bool needsResync = false;
@@ -295,7 +289,6 @@ bool SyncAnchors(ReadOnlyCollection<VFXDataAnchorController> ports, VisualElemen
 
             if (hasActivationPort)
                 UpdateActivationPortPositionIfAny(); // Needed to account for expanded state change in case of undo/redo
-            return needsResync;
         }
 
         private void UpdateActivationPortPosition(VFXDataAnchor anchor)
@@ -416,18 +409,15 @@ protected virtual void SelfChange()
 
             base.expanded = controller.expanded;
 
-            var needRefresh = SyncSettings();
-            needRefresh |= SyncAnchors();
+            SyncSettings();
+            SyncAnchors();
             Profiler.BeginSample("VFXNodeUI.SelfChange The Rest");
             RefreshExpandedState();
             Profiler.EndSample();
             Profiler.EndSample();
 
             UpdateCollapse();
-            if (needRefresh)
-            {
-                EditorApplication.delayCall += RefreshLayout;
-            }
+            RefreshLayout();
         }
 
         protected virtual VFXDataAnchor InstantiateDataAnchor(VFXDataAnchorController ctrl, VFXNodeUI node)
@@ -520,18 +510,23 @@ private PropertyRM AddSetting(VFXSettingController setting)
             return rm;
         }
 
+        public void GetWidths(out float labelWidth, out float controlWidth)
+        {
+            var settingsLabelWidth = 0f;
+            var inputsLabelWidth = 0f;
+            controlWidth = 50f;
+            GetPreferredSettingsWidths(ref settingsLabelWidth, ref controlWidth);
+            GetPreferredWidths(ref inputsLabelWidth, ref controlWidth);
+            labelWidth = Mathf.Max(settingsLabelWidth, inputsLabelWidth);
+            if (labelWidth > 0)
+                labelWidth = Mathf.Max(labelWidth, defaultLabelWidth);
+        }
+
         protected virtual void RefreshLayout()
         {
             if (expanded)
             {
-                var settingsLabelWidth = 0f;
-                var inputsLabelWidth = 0f;
-                var controlWidth = 50f;
-                GetPreferredSettingsWidths(ref settingsLabelWidth, ref controlWidth);
-                GetPreferredWidths(ref inputsLabelWidth, ref controlWidth);
-                var labelWidth = Mathf.Max(settingsLabelWidth, inputsLabelWidth);
-                if (labelWidth > 0)
-                    labelWidth = Mathf.Max(labelWidth, defaultLabelWidth);
+                GetWidths(out var labelWidth, out var controlWidth);
                 ApplySettingsWidths(labelWidth);
                 ApplyWidths(labelWidth, controlWidth);
             }

Packages/com.unity.visualeffectgraph/Editor/GraphView/Elements/VFXOperatorUI.cs

@@ -60,13 +60,6 @@ protected override void OnNewController()
                 if (m_EditContainer != null)
                     m_EditContainer.name = "edit-container";
             }
-
-        }
-
-        protected override void ApplyWidths(float labelWidth, float controlWidth)
-        {
-            base.ApplyWidths(labelWidth, controlWidth);
-            inputContainer.style.width = labelWidth + controlWidth + 20;
         }
 
         private bool isEditable => controller != null && controller.isEditable;

Packages/com.unity.visualeffectgraph/Editor/UIResources/uss/PropertyRM.uss

@@ -219,10 +219,11 @@ Vector3PropertyRM.propertyrm VFXVector3Field.fieldContainer
     flex: 1 0 auto;
 }
 
-VFXVector3Field FloatField {
+VFXVector3Field .unity-float-field {
     margin-left: 4px;
 }
 
+
 ColorPropertyRM .unity-float-field
 {
     flex: 1 0 auto;
@@ -386,3 +387,7 @@ VFXColorField .colorcontainer
 .propertyrm.hasDepth > .unity-base-field {
     margin-left: 4px;
 }
+
+.fieldContainer .unity-base-text-field__input {
+    width: 36px;
+}

Packages/com.unity.visualeffectgraph/Editor/UIResources/uss/VFXContext.uss

@@ -346,11 +346,6 @@ VFXContextUI > #node-border > #inside > #contents
     background-color: rgba(45,45,45,0.8);
 }
 
-VFXContextUI ColorPropertyRM .fieldContainer > *
-{
-    width: 56px;
-}
-
 VFXContextUI .subtitle
 {
     align-self:center;