Skip to content

Commit aa21871

Browse files
giorgospetkakisEvergreen
authored andcommitted
Enable RuntimeProfilerGivesNonZeroOutput, Remove Hardcoded string from SRP Recipes
[GFXFOUND-327](https://jira.unity3d.com/browse/GFXFOUND-327) Enables a disabled test on certain platforms -- looking at the previously ignored platforms: - [Passes on Linux](https://unity-ci.cds.internal.unity3d.com/job/37741645/logs/execution?line=3032&q=Profiler) - [Passes on Windows DX12](https://unity-ci.cds.internal.unity3d.com/job/37741655/logs/execution?r=37741655&line=6948&q=Profiler) - [Passes on Windows DX12 XR](https://unity-ci.cds.internal.unity3d.com/job/37741650/logs/execution?r=37741650&line=3147&q=Profiler) - [Ignored on WebGL](https://unity-ci.cds.internal.unity3d.com/job/37741651/logs/execution?line=3807&q=Profiler) - [Ignored on Quest](https://unity-ci.cds.internal.unity3d.com/job/37741657/logs/execution?r=37741657&line=3330&q=Profiler) This test was disabled by hardcoding a string into the TestFilter argument of recipes which overrode the test filter given through Yamato UI etc. I would consider this an unfavorable practice as it's a quite surprising way of disabling a test. It is also blocking a certain effort to bring test filtering to the Graphics Test Framework. Unfortunately, I could not find any way of disabling it on Quest **only** so I had to disable it on all Android platforms. Therefore, effectively this PR enables the test on Windows DX12 and Linux but disables it on Android devices including Quest.
1 parent a449f38 commit aa21871

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

Packages/com.unity.render-pipelines.core/Tests/Runtime/RuntimeProfilerTests.cs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,22 @@ protected IEnumerator Warmup()
5555
}
5656
}
5757

58-
[UnityPlatform(exclude = new RuntimePlatform[] { RuntimePlatform.LinuxPlayer, RuntimePlatform.LinuxEditor })] // Disabled on Linux (case 1370861)
58+
// Fails on WebGL and Oculus Quest.
59+
// Unfortunately, there is no good way to exclude Oculus Quest from the test without excluding all Android devices.
60+
// https://jira.unity3d.com/browse/GFXFOUND-559
61+
[UnityPlatform(exclude = new RuntimePlatform[] { RuntimePlatform.WebGLPlayer, RuntimePlatform.Android })]
5962
class RuntimeProfilerTests : RuntimeProfilerTestBase
6063
{
6164
[UnityTest]
6265
public IEnumerator RuntimeProfilerGivesNonZeroOutput()
6366
{
67+
if ((Application.platform == RuntimePlatform.LinuxPlayer ||
68+
Application.platform == RuntimePlatform.LinuxEditor)
69+
&& SystemInfo.graphicsDeviceType == GraphicsDeviceType.OpenGLCore)
70+
{
71+
Assert.Ignore("Test is failing on Linux OpenGLCore. https://jira.unity3d.com/browse/GFXFOUND-559");
72+
}
73+
6474
yield return Warmup();
6575

6676
m_ToCleanup = new GameObject();

0 commit comments

Comments
 (0)