[VFX/Test] Add Minimal Coverage for Samples

Add basic validation check for additional sample and fix couple of known issue:
- Warning as error generating issue with `kMouseX` & `kMouseY`
- Not up to date script in package (velocity has been deprecated, replaced by linearVelocity)
- Corrupted ShaderGraph file see f6aac94712e73c970305122a2e90f90e473df0c7
Bonus: upgrade sample script to ease @orson-favrel upgrades. This test is among update but isn't included in upgrade suite, it can only be launched locally, see in action:

N.B.: I moved `Tests/SRPTests/Projects/VisualEffectGraph_HDRP/Assets/Samples/` to another path because test are simply wiping this folder in test. It prevents imported data being mixed with versioned data.

Author: PaulDemeulenaere

Packages/com.unity.render-pipelines.core/Samples~/Common/TextMesh Pro/Resources/Fonts & Materials/SamplesLit_Inter.shadergraph

@@ -604,24 +604,6 @@
     }
 }
 
-{
-    "m_SGVersion": 2,
-    "m_Type": "UnityEditor.Rendering.BuiltIn.ShaderGraph.BuiltInTarget",
-    "m_ObjectId": "11e879f62c0d472e9330636a29adfcaa",
-    "m_Datas": [],
-    "m_ActiveSubTarget": {
-        "m_Id": "b844ef3864e3479fbb65c83c4867b45e"
-    },
-    "m_AllowMaterialOverride": false,
-    "m_SurfaceType": 1,
-    "m_ZWriteControl": 0,
-    "m_ZTestMode": 4,
-    "m_AlphaMode": 0,
-    "m_RenderFace": 2,
-    "m_AlphaClip": false,
-    "m_CustomEditorGUI": ""
-}
-
 {
     "m_SGVersion": 0,
     "m_Type": "UnityEditor.ShaderGraph.Vector1MaterialSlot",

Packages/com.unity.visualeffectgraph/Editor/SamplesLinkPackageManagerExtension.cs

@@ -31,6 +31,9 @@ static SamplesLinkPackageManagerExtension()
 
     void IPackageManagerExtension.OnPackageSelectionChange(PackageInfo packageInfo)
     {
+        if (samplesButton == null)
+            return;
+
         // Prevent the button from rendering on other packages
         if (samplesButton.parent != null)
             parent = samplesButton.parent;

Packages/com.unity.visualeffectgraph/Samples~/VFXOutputEventHandlers/Runtime/VFXOutputEventPrefabAttributeRigidBodyVelocityHandler.cs

@@ -23,7 +23,7 @@ public override void OnVFXEventAttribute(VFXEventAttribute eventAttribute, Visua
             if (TryGetComponent<Rigidbody>(out m_RigidBody))
             {
                 m_RigidBody.WakeUp();
-                m_RigidBody.velocity = velocity;
+                m_RigidBody.linearVelocity = velocity;
             }
         }
     }

Tests/SRPTests/Packages/com.unity.testing.visualeffectgraph/Tests/Editor/VFXAdditionalPackageTest.cs

@@ -0,0 +1,102 @@
+using System.Collections;
+using System.IO;
+using System.Linq;
+using NUnit.Framework;
+using UnityEditor.Compilation;
+using UnityEditor.PackageManager;
+using UnityEditor.PackageManager.UI;
+using UnityEngine;
+using UnityEngine.TestTools;
+using UnityEngine.VFX;
+
+namespace UnityEditor.VFX.Test
+{
+    [TestFixture]
+    public class VFXAdditionalPackageTest
+    {
+        public static string[] kAdditionalSampleMatches = new [] {"Additions", "Helpers", "Learning"};
+
+        private static readonly string kSampleExpectedPath = "Assets/Samples";
+
+        [SerializeField]
+        private static string m_CurrentMatch;
+
+        [UnityTest, Timeout(10 * 60 * 1000)]
+        public IEnumerator Check_Additional_Doesnt_Generate_Any_Errors([ValueSource(nameof(kAdditionalSampleMatches))] string expectedMatch)
+        {
+            m_CurrentMatch = expectedMatch;
+
+            if (Directory.Exists(kSampleExpectedPath))
+            {
+                AssetDatabase.DeleteAsset(kSampleExpectedPath);
+                CompilationPipeline.RequestScriptCompilation();
+                yield return new WaitForDomainReload();
+            }
+
+            Assert.IsFalse(Directory.Exists(kSampleExpectedPath));
+            var searchRequest = Client.Search("com.unity.visualeffectgraph", true);
+            while (!searchRequest.IsCompleted)
+            {
+                yield return null;
+            }
+
+            Assert.AreEqual(StatusCode.Success, searchRequest.Status);
+            Assert.AreEqual(1, searchRequest.Result.Length);
+
+            var version = searchRequest.Result[0].version;
+            Assert.IsFalse(string.IsNullOrEmpty(version));
+
+            var allSample = Sample.FindByPackage("com.unity.visualeffectgraph", version).ToArray();
+            Assert.AreEqual(3, allSample.Length);
+
+            var matching = allSample.Where(o => o.displayName.Contains(m_CurrentMatch)).ToArray();
+            Assert.AreEqual(1, matching.Length);
+
+            //Workaround for UUM-63664
+            var current = matching[0];
+            {
+                foreach (var extension in PackageManagerExtensions.Extensions)
+                    extension.OnPackageSelectionChange(searchRequest.Result[0]);
+
+                //Force import of dependencies before importing anything else
+                var samplePath = Path.Combine(kSampleExpectedPath, "Visual Effect Graph", version, current.displayName);
+                Directory.CreateDirectory(samplePath);
+                File.WriteAllText(samplePath + "/dummy.txt", "UUM-63664 workaround for test.");
+                AssetDatabase.Refresh(ImportAssetOptions.ForceUpdate);
+            }
+
+            var result = current.Import(Sample.ImportOptions.HideImportWindow | Sample.ImportOptions.OverridePreviousImports);
+            Assert.IsTrue(result);
+
+            CompilationPipeline.RequestScriptCompilation();
+            yield return new WaitForDomainReload();
+
+            Assert.IsTrue(Directory.Exists(kSampleExpectedPath));
+            if (m_CurrentMatch == "Learning")
+            {
+                //Extra check for learning sample consistency
+                foreach (var guid in AssetDatabase.FindAssets("t:VisualEffectAsset", new[] { kSampleExpectedPath }))
+                {
+                    var path = AssetDatabase.GUIDToAssetPath(guid);
+                    var vfxAsset = AssetDatabase.LoadAssetAtPath<VisualEffectAsset>(path);
+                    var graph = vfxAsset.GetResource().GetOrCreateGraph();
+
+                    foreach (var initialize in graph.children.OfType<VFXBasicInitialize>())
+                    {
+                        var dataParticle = initialize.GetData() as VFXDataParticle;
+                        Assert.IsNotNull(dataParticle);
+                        Assert.AreEqual(BoundsSettingMode.Manual, dataParticle.boundsMode);
+                    }
+
+                    Assert.IsTrue(graph.children.OfType<VFXAbstractRenderedOutput>().Any());
+                    Assert.IsTrue(graph.UIInfos.stickyNoteInfos.Length > 0);
+                }
+            }
+            m_CurrentMatch = null;
+
+            AssetDatabase.DeleteAsset(kSampleExpectedPath);
+            CompilationPipeline.RequestScriptCompilation();
+            yield return new WaitForDomainReload();
+        }
+    }
+}

Tests/SRPTests/Packages/com.unity.testing.visualeffectgraph/Tests/Editor/VFXAdditionalPackageTest.cs.meta

@@ -6,6 +6,9 @@
 using System.Collections;
 using System.IO;
 using Object = UnityEngine.Object;
+using UnityEditor.PackageManager;
+using UnityEditor.PackageManager.UI;
+using UnityEditor.Compilation;
 
 //Not strictly test, these helpers are used to upgrade project
 namespace UnityEditor.VFX.Update
@@ -76,13 +79,102 @@ public IEnumerator Upgrade_Many_VFX_Package()
             }
             AssetDatabase.ExportPackage(exportedPackageAssetList.ToArray(), absolutePath, ExportPackageOptions.Recurse);
             yield return null;
-            Directory.Delete(expectedDirectory, true);
-            File.Delete(expectedDirectory + ".meta");
+
+            AssetDatabase.DeleteAsset(expectedDirectory);
             yield return null;
             Debug.unityLogger.logHandler = quietLog.m_ForwardLog;
 
             Assert.IsFalse(Directory.Exists(expectedDirectory));
         }
+
+        private static void CopyFiles(string sourcePath, string targetPath)
+        {
+            foreach (var dirPath in Directory.GetDirectories(sourcePath, "*", SearchOption.AllDirectories))
+            {
+                Directory.CreateDirectory(dirPath.Replace(sourcePath, targetPath));
+            }
+
+            foreach (var newPath in Directory.GetFiles(sourcePath, "*.*", SearchOption.AllDirectories))
+            {
+                File.Copy(newPath, newPath.Replace(sourcePath, targetPath), true);
+            }
+        }
+
+
+        [SerializeField] private string m_Version;
+        private static readonly string kSampleExpectedBasePath = "Assets/Samples";
+
+        [UnityTest, Timeout(6000 * 1000)]
+        public IEnumerator Upgrade_Additional_Sample()
+        {
+            var searchRequest = Client.Search("com.unity.visualeffectgraph", true);
+            while (!searchRequest.IsCompleted)
+            {
+                yield return null;
+            }
+
+            Assert.AreEqual(StatusCode.Success, searchRequest.Status);
+            Assert.AreEqual(1, searchRequest.Result.Length);
+            m_Version = searchRequest.Result[0].version;
+
+            var addRequest = Client.Add(@"file:../../../../../Packages/com.unity.render-pipelines.universal");
+            while (!addRequest.IsCompleted)
+                yield return null;
+            Assert.AreEqual(StatusCode.Success, addRequest.Status);
+
+            //Workaround for UUM-63664
+            {
+                var tempSamples = Sample.FindByPackage("com.unity.visualeffectgraph", m_Version);
+                foreach (var extension in PackageManagerExtensions.Extensions)
+                    extension.OnPackageSelectionChange(searchRequest.Result[0]);
+                foreach (var sample in tempSamples)
+                {
+                    //Force import of dependencies before importing anything else
+                    var samplePath = Path.Combine(kSampleExpectedBasePath, "Visual Effect Graph", m_Version, sample.displayName);
+                    Directory.CreateDirectory(samplePath);
+                    var dummy = samplePath + "/dummy.txt";
+                    File.WriteAllText(dummy, "UUM-63664 workaround for test.");
+                    AssetDatabase.Refresh(ImportAssetOptions.ForceUpdate);
+                    AssetDatabase.DeleteAsset(dummy);
+                }
+            }
+
+            CompilationPipeline.RequestScriptCompilation();
+            yield return new WaitForDomainReload();
+
+            var samples = Sample.FindByPackage("com.unity.visualeffectgraph", m_Version);
+            foreach (var sample in samples)
+            {
+                var result = sample.Import(Sample.ImportOptions.HideImportWindow | Sample.ImportOptions.OverridePreviousImports);
+                Assert.IsTrue(result);
+            }
+
+            //VFXAssetManager.Build(true); //Shouldn't be needed to upgrade dirty imported asset
+            AssetDatabase.SaveAssets();
+
+            var baseTarget = @"../../../../Packages/com.unity.visualeffectgraph";
+            Directory.Delete(baseTarget + "/Samples~", true);
+
+            var commonAssetPath = Path.Combine(kSampleExpectedBasePath, "Visual Effect Graph", "Common");
+            var commonTargetPath = Path.Combine(baseTarget, "Samples~", "Common");
+            CopyFiles(commonAssetPath, commonTargetPath);
+
+            samples = Sample.FindByPackage("com.unity.visualeffectgraph", m_Version);
+            foreach (var sample in samples)
+            {
+                var assetPath = Path.Combine(kSampleExpectedBasePath, "Visual Effect Graph", m_Version, sample.displayName);
+                var targetPath = sample.resolvedPath;
+                CopyFiles(assetPath, targetPath);
+            }
+            AssetDatabase.DeleteAsset(kSampleExpectedBasePath);
+
+            var removeRequest = Client.Remove("com.unity.render-pipelines.universal");
+            while (!removeRequest.IsCompleted)
+                yield return null;
+            Assert.AreEqual(StatusCode.Success, removeRequest.Status);
+            yield return new WaitForDomainReload();
+        }
+
 #endif
     }
 }