Skip to content

Commit c12d059

Browse files
julienamsellemEvergreen
authored andcommitted
[VFX] Avoid file forbidden characters in shortcut name
Jira: https://jira.unity3d.com/browse/UUM-71918 Steps to reproduce: - Create a Project and Install the Visual Effect Graph Package - In the Project Browser right-click and Create > Visual Effects > Visual Effect Graph - Double click any of the Templates - Open the Asset Actual results Error "ArgumentException: Illegal characters in path. System.IO.Path.GetFileName (System.String path) (at <a35250a304174d009b77e5c5f6695f54>:0) UnityEditor.ShortcutManagement.HelperWindow+<>c.<UpdateContext>b__7_2 (UnityEditor.ShortcutManagement.ShortcutEntry s) (at <7b4ba97968ea4dd39e76baa286b7953f>:0)" logged when opening the Asset or manipulating the VFX Graph Window Expected results No Error issues when creating VFX Graphs Reproducible with versions: 2023.3.0b1, 6000.0.2f1 Not reproducible with versions: 2021.3.38f1, 2022.3.39f1, 2023.1.20f1, 2023.2.20f1, 2023.3.0a19 Tested on (OS): Windows 11 (Reproducible), macOS Sonoma (Not reproducible) ![Unity_71b8EGIxFI](https://media.github.cds.internal.unity3d.com/user/4003/files/123c964b-9bc6-4ce5-9877-b40aaa11a30d) ![Unity_ok6X5WIBG8](https://media.github.cds.internal.unity3d.com/user/4003/files/d005f6ee-3ada-47e9-9931-7672343181c4)
1 parent e9b4a98 commit c12d059

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Packages/com.unity.visualeffectgraph/Editor/VisualEffectGraphShortcuts.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static void ConvertToSubgraphOperator(ShortcutArguments args)
233233
}
234234
}
235235

236-
[Shortcut("Visual Effect Graph/Toggle Property<->Inline", typeof(VFXViewWindow), KeyCode.X, ShortcutModifiers.Shift)]
236+
[Shortcut("Visual Effect Graph/Toggle Property--Inline", typeof(VFXViewWindow), KeyCode.X, ShortcutModifiers.Shift)]
237237
static void ToggleNodePropertyOrInline(ShortcutArguments args)
238238
{
239239
if (args.context is VFXViewWindow window)

0 commit comments

Comments
 (0)