Skip to content

Commit 12ee89a

Browse files
authored
FIX: The "Add Control Scheme..." popup now requires explicit Save/Close user action (case ISXB-1131) (#2044)
* [Input System] The "Add Control Scheme..." popup now requires explicit Save/Close user action (case ISXB-1131) o Previously clicking outside the popup window (anywhere in the editor) would close the popup window. o This would leave a new blank (unnamed, orphaned) control scheme populating the UI - this was confusing. o Now this popup will persist until the user explictly chooses to Save or Cancel. * [Input System] Added CHANGELOG entry for "Add Control Scheme..." popup fix (case ISXB-1131) * [Input System] Fix typo in CHANGELOG entry - removed extraneous final closing parenthesis. * [Input System] Licensing failure - try limiting to version 2021.3.45f
1 parent 08349cc commit 12ee89a

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

.yamato/config.metadata

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
editors:
2-
- version: 2021.3
2+
- version: 2021.3.45f
33
- version: 2022.3
44
disable_tvos_run: true
55
- version: 6000.0

Packages/com.unity.inputsystem/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ however, it has to be formatted properly to pass verification tests.
1818
- Fixed ISubmitHandler.OnSubmit event processing when operating in Manual Update mode (ISXB-1141)
1919
- Fixed Rename mode is not entered and name is autocompleted to default when creating a new Action Map on 2022.3. [ISXB-1151](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1151)
2020
- Fixed unexpected control scheme switch when using `OnScreenControl` and pointer based schemes which registed "Cancel" event on every frame.[ISXB-656](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-656)
21+
- Fixed an issue with The "Add Control Scheme..." popup window so that it now persists until any changes are explicitly Saved or Cancelled [case ISXB-1131](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1131)
2122

2223
### Changed
2324
- Added back the InputManager to InputSystem project-wide asset migration code with performance improvement (ISX-2086)

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ControlSchemesView.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ public ControlSchemesView(VisualElement root, StateContainer stateContainer, boo
6363
m_ModalWindow.Add(popupWindow);
6464
root.Add(m_ModalWindow);
6565
m_ModalWindow.StretchToParentSize();
66-
m_ModalWindow.RegisterCallback<ClickEvent>(evt => CloseView());
6766
popupWindow.RegisterCallback<ClickEvent>(evt => evt.StopPropagation());
6867

6968
m_ListView = controlSchemeVisualElement.Q<MultiColumnListView>(kControlSchemesListView);

0 commit comments

Comments
 (0)