Skip to content

Commit 2cc1362

Browse files
committed
Improvements based on PR review
1 parent 0c1d43c commit 2cc1362

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

Packages/com.unity.inputsystem/InputSystem/Devices/Gamepad.cs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,9 @@ public struct GamepadState : IInputStateTypeInfo
142142
/// <summary>
143143
/// A 2D vector representing the current position of the right stick on a gamepad.
144144
/// </summary>
145-
/// <remarks>Each axis of the 2D vector's range goes from -1 to 1. 0 represents the stick in its center position, and -1 or 1 represents the the stick pushed to its extent in each direction along the axis.</remarks>
145+
/// <remarks>Each axis of the 2D vector's range goes from -1 to 1.
146+
/// 0 represents the stick in its center position.
147+
/// -1 or 1 represents the stick pushed to its extent in each direction along the axis.</remarks>
146148
/// <seealso cref="Gamepad.rightStick"/>
147149
[InputControl(layout = "Stick", usage = "Secondary2DMotion", processors = "stickDeadzone", displayName = "Right Stick", shortDisplayName = "RS")]
148150
[FieldOffset(12)]
@@ -153,7 +155,9 @@ public struct GamepadState : IInputStateTypeInfo
153155
/// <summary>
154156
/// The current position of the left trigger on a gamepad.
155157
/// </summary>
156-
/// <remarks>The value's range goes from 0 to 1, where 0 represents the trigger not pressed at all, and 1 represents the trigger in its fully pressed position.</remarks>
158+
/// <remarks>The value's range goes from 0 to 1.
159+
/// 0 represents the trigger in its neutral position.
160+
/// 1 represents the trigger in its fully pressed position.</remarks>
157161
/// <seealso cref="Gamepad.leftTrigger"/>
158162
[InputControl(layout = "Button", format = "FLT", usage = "SecondaryTrigger", displayName = "Left Trigger", shortDisplayName = "LT")]
159163
[FieldOffset(20)]
@@ -162,7 +166,9 @@ public struct GamepadState : IInputStateTypeInfo
162166
/// <summary>
163167
/// The current position of the right trigger on a gamepad.
164168
/// </summary>
165-
/// <remarks>The value's range goes from 0 to 1, where 0 represents the trigger not pressed at all, and 1 represents the trigger in its fully pressed position.</remarks>
169+
/// <remarks>The value's range goes from 0 to 1.
170+
/// 0 represents the trigger in its neutral position.
171+
/// 1 represents the trigger in its fully pressed position.</remarks>
166172
/// <seealso cref="Gamepad.rightTrigger"/>
167173
[InputControl(layout = "Button", format = "FLT", usage = "SecondaryTrigger", displayName = "Right Trigger", shortDisplayName = "RT")]
168174
[FieldOffset(24)]
@@ -632,7 +638,7 @@ public ButtonControl this[GamepadButton button]
632638
/// you need it. Whenever the gamepad setup changes, the value returned by this getter
633639
/// is invalidated.
634640
///
635-
/// Alternately, if you want a single gamepad, you can use <see cref="current"/> for example.
641+
/// Alternately, for querying a single gamepad, you can use <see cref="current"/> for example.
636642
/// </remarks>
637643
public new static ReadOnlyArray<Gamepad> all => new ReadOnlyArray<Gamepad>(s_Gamepads, 0, s_GamepadCount);
638644

Packages/com.unity.inputsystem/InputSystem/Devices/Haptics/DualMotorRumble.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ internal struct DualMotorRumble
3939
|| !Mathf.Approximately(highFrequencyMotorSpeed, 0f);
4040

4141
/// <summary>
42-
/// Reset motor speeds to zero.
42+
/// Stops haptics by setting motor speeds to zero.
4343
/// </summary>
4444
/// <remarks>
4545
/// Sets both motor speeds to zero while retaining the current values for <see cref="lowFrequencyMotorSpeed"/>

0 commit comments

Comments
 (0)