You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: Assets/Tests/InputSystem/CoreTests_Actions_Reference.cs
+1-16Lines changed: 1 addition & 16 deletions
Original file line number
Diff line number
Diff line change
@@ -195,20 +195,5 @@ public void Actions_Reference_ShouldReevaluateIfAssociatedEntityIsDeleted(Type t
195
195
//Assert.That(reference.ToString(), Is.EqualTo(":" + new Guid(action1.m_Id))); // Unexpected when no longer existing
196
196
}
197
197
198
-
// List of bugs addressed on this branch:
199
-
// (FIXED) InputActionReference - Do not set m_Action when calling Set.
200
-
// (FIXED) InputActionReference.asset - Returns incorrect asset after being .Set if .action is called before Set.
201
-
// (FIXED) InputActionReference - Assigned with Set during play-mode corrupts InputActionAsset by mutating asset reference into pointing into potentially another asset and overwrites existign asset.
202
-
// (FIXED) InputActionReferencePropertyDrawer - Assigns direct reference into InputActionAsset to InputActionReference fields leading to corruption.
203
-
// (SOMEWHAT FIXED) InputActionReference - Contains stale reference and looks like a valid reference if the action is deleted. .action returns removed action. This is a presentation (UI) issue, reference should be fixed when referenced entities are removed to allow resolving itself after e.g. Undo.
204
-
// (FIXED) InputActionReference - Do not invalidate if action, action map or asset is deleted/destroyed. .action still returns the action.
205
-
// (FIXED) InputActionAsset.RemoveActionMap - Do not remove actions within the map and they keep a stale reference to the removed map.
206
-
// (FIXED) InputActionAsset.RemoveAction - Throws exception if action do not have any bindings.
207
-
// (FIXED) InputActionReference.Set(null) - Does not update m_Action. Hence .actions returns an incorrect reference. Also doesn't update ScriptableObject.name consistently with default ScriptableObject.
208
-
// (FIXED) InputActionReference.Create - Returns null if action is null which is not inline with xmldoc description and inconsistent since it is allowed to create a reference and set it to null. If you want a null reference you should not call Create in the first place.
209
-
// InputActionSerializationHelpers.RemoveAction - Isn't removing InputActionReference objects. This might be a bug unless importer will make sure the object is deleted.
210
-
211
-
// TODO Make a test where action map is deleted
212
-
// TODO Make a test where asset is deleted
213
-
// TODO Make an undo resolve test
198
+
// TODO Make an undo resolve test that destroys reference sub-asset, breaks reference, then undo and reference is valid again.
0 commit comments