Merge branch 'develop' into isxb-1024-action-navigation-after-rename

Author: tspiller

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -20,6 +20,7 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed unexpected control scheme switch when using `OnScreenControl` and pointer based schemes which registed "Cancel" event on every frame.[ISXB-656](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-656).
 - Fixed an issue with The "Add Control Scheme..." popup window so that it now persists until any changes are explicitly Saved or Cancelled [case ISXB-1131](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1131).
 - Fixed missing documentation for source generated Input Action Assets. This is now generated as part of the source code generation step when "Generate C# Class" is checked in the importer inspector settings.
+- Fixed pasting into an empty map list raising an exception. [ISXB-1150](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1150)
 - Fixed arrow key navigation of Input Actions after Action rename. [ISXB-1024](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1024)
 
 ### Changed

Packages/com.unity.inputsystem/InputSystem/Devices/Mouse.cs

@@ -26,6 +26,10 @@ public struct MouseState : IInputStateTypeInfo
         /// Screen-space position of the mouse in pixels.
         /// </summary>
         /// <value>Position of mouse on screen.</value>
+        /// <remarks>
+        /// On Windows, delta originates from RAWINPUT API.
+        /// Note: This value might not update every frame, particularly if your project is running at a high frame rates. This value might also update at a different time than the <see cref="Pointer.delta"/>. If you need a delta value that correlates with position, you should compute it based on the previous position value.
+        /// </remarks>
         /// <seealso cref="Pointer.position"/>
         [InputControl(usage = "Point", dontReset = true)] // Mouse should stay put when we reset devices.
         [FieldOffset(0)]
@@ -35,6 +39,10 @@ public struct MouseState : IInputStateTypeInfo
         /// Screen-space motion delta of the mouse in pixels.
         /// </summary>
         /// <value>Mouse movement.</value>
+        /// <remarks>
+        /// On Windows, delta originates from RAWINPUT API.
+        /// Note: This value might not update every frame, particularly if your project is running at a high frame rates. This value might also update at a different time than the <see cref="Pointer.position"/>. If you need a delta value that correlates with position, you should compute it based on the previous position value.
+        /// </remarks>
         /// <seealso cref="Pointer.delta"/>
         [InputControl(usage = "Secondary2DMotion", layout = "Delta")]
         [FieldOffset(8)]

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/CopyPasteHelper.cs

@@ -243,6 +243,9 @@ internal static void PasteItems(string copyBufferString, int[] indicesToInsert,
             // Split buffer into transmissions and then into transmission blocks
             var copiedType = GetCopiedType(copyBufferString);
             int indexOffset = 0;
+            // If the array is empty, make sure we insert at index 0
+            if (arrayToInsertInto.arraySize == 0)
+                indexOffset = -1;
             foreach (var transmission in copyBufferString.Substring(k_CopyPasteMarker.Length + k_TypeMarker[copiedType].Length)
                      .Split(new[] {k_EndOfTransmission}, StringSplitOptions.RemoveEmptyEntries))
             {

Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/Selectors.cs

@@ -114,7 +114,12 @@ public static int GetSelectedBindingIndexAfterCompositeBindings(InputActionsEdit
 
         public static int GetBindingIndexBeforeAction(SerializedProperty arrayProperty, int indexToInsert, SerializedProperty bindingArrayToInsertTo)
         {
-            Debug.Assert(indexToInsert >= 0 && indexToInsert <= arrayProperty.arraySize, "Invalid action index to insert bindings before.");
+            // Need to guard against this case, as there is different behaviour when pasting actions vs actionmaps
+            if (indexToInsert < 0)
+            {
+                return -1;
+            }
+            Debug.Assert(indexToInsert <= arrayProperty.arraySize, "Invalid action index to insert bindings before.");
             var offset = 1; //previous action offset
             while (indexToInsert - offset >= 0)
             {