review feedback & small change in FPS test

Author: stefanunity

Assets/Tests/InputSystem/CorePerformanceTests.cs

@@ -1126,8 +1126,9 @@ public void Performance_OptimizedControls_ReadingPose4kTimes(OptimizationTestTyp
 
     [PrebuildSetup(typeof(ProjectWideActionsBuildSetup))]
     [PostBuildCleanup(typeof(ProjectWideActionsBuildSetup))]
-    [UnityTest, Performance]
+    [UnityTest, Performance, Version("2")]
     [Category("Performance")]
+    // Simulate a FPS controller with WASD, mouse look and various key presses triggering actions
     public IEnumerator Performance_MeasureInputSystemFrameTimeWithProfilerMarkers_FPS()
     {
         var keyboard = InputSystem.AddDevice<Keyboard>();
@@ -1169,6 +1170,7 @@ public IEnumerator Performance_MeasureInputSystemFrameTimeWithProfilerMarkers_FP
             {
                 if (i % 60 == 0)
                 {
+                    PressAndRelease(keyboard.wKey, queueEventOnly: true);
                     PressAndRelease(keyboard.aKey, queueEventOnly: true);
                     PressAndRelease(keyboard.sKey, queueEventOnly: true);
                     PressAndRelease(keyboard.dKey, queueEventOnly: true);
@@ -1211,6 +1213,8 @@ public IEnumerator Performance_MeasureInputSystemFrameTimeWithProfilerMarkers_Do
     [PostBuildCleanup(typeof(ProjectWideActionsBuildSetup))]
     [UnityTest, Performance]
     [Category("Performance")]
+    // Simulate a touch FPS controller with one constantly moving touch as the WASD equivalent
+    // and taps/clicks for button presses. Actions from PWA getting triggered.
     public IEnumerator Performance_MeasureInputSystemFrameTimeWithProfilerMarkers_Touch()
     {
         var touchscreen = InputSystem.AddDevice<Touchscreen>();
@@ -1231,26 +1235,34 @@ public IEnumerator Performance_MeasureInputSystemFrameTimeWithProfilerMarkers_To
 
         using (Measure.ProfilerMarkers(allInputSystemProfilerMarkers))
         {
+            // start touch 1
             BeginTouch(1, new Vector2(0.1f, 0.2f), queueEventOnly: true);
-            BeginTouch(2, new Vector2(0.3f, 0.4f), queueEventOnly: true);
 
             for (int i = 0; i < 500; ++i)
             {
-                MoveTouch(1, new Vector2(0.1f + i, 0.2f + i), queueEventOnly: true);
+                // start touch 2
+                BeginTouch(2, new Vector2(0.3f, 0.4f), queueEventOnly: true);
                 MoveTouch(2, new Vector2(0.3f + i, 0.4f + i), queueEventOnly: true);
 
+                // tap touch 3 once per frame
                 BeginTouch(3, new Vector2(0.5f, 0.6f), queueEventOnly: true);
                 MoveTouch(3, new Vector2(0.5f + i, 0.6f + i), queueEventOnly: true);
                 EndTouch(3, new Vector2(0.7f, 0.7f), queueEventOnly: true);
 
                 if (i % 60 == 0)
                 {
-                    EndTouch(1, new Vector2(0.8f, 0.8f), queueEventOnly: true);
+                    // end and restart touch 2 every 30 frames
                     EndTouch(2, new Vector2(0.9f, 0.9f), queueEventOnly: true);
-                    BeginTouch(1, new Vector2(0.1f, 0.2f), queueEventOnly: true);
                     BeginTouch(2, new Vector2(0.3f, 0.4f), queueEventOnly: true);
                 }
 
+                // move touch 1 with higher frequency assuming higher touch sampling rate then frames drawn
+                // 120Hz screen refresh rate & 2k+ Hz touch sampling rate
+                for (int j = 1; j <= 20; j++)
+                {
+                    MoveTouch(1, new Vector2(0.1f + j, 0.2f + j), queueEventOnly: true);
+                }
+
                 InputSystem.Update();
 
                 yield return null;