Fix parsing signed bytes and incorrect byte reading for 4 bytes

jfreire-unity · jfreire-unity · commit 9a5f397a0f3d · 2025-09-26T13:10:17.000+01:00
diff --git a/Packages/com.unity.inputsystem/InputSystem/Plugins/HID/HIDParser.cs b/Packages/com.unity.inputsystem/InputSystem/Plugins/HID/HIDParser.cs
@@ -267,7 +267,7 @@ private unsafe static int ReadData(int itemSize, byte* currentPtr, byte* endPtr)
             {
                 if (currentPtr >= endPtr)
                     return 0;
-                return *currentPtr;
+                return (sbyte)*currentPtr;
             }
 
             // Read short.
@@ -291,7 +291,7 @@ private unsafe static int ReadData(int itemSize, byte* currentPtr, byte* endPtr)
                 var data3 = *(currentPtr + 2);
                 var data4 = *(currentPtr + 3);
 
-                return (data4 << 24) | (data3 << 24) | (data2 << 8) | data1;
+                return (data4 << 24) | (data3 << 16) | (data2 << 8) | data1;
             }
 
             Debug.Assert(false, "Should not reach here");

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ private unsafe static int ReadData(int itemSize, byte* currentPtr, byte* endPtr)`
`267`	`267`	`{`
`268`	`268`	`if (currentPtr >= endPtr)`
`269`	`269`	`return 0;`
`270`		`- return *currentPtr;`
	`270`	`+ return (sbyte)*currentPtr;`
`271`	`271`	`}`
`272`	`272`
`273`	`273`	`// Read short.`
`@@ -291,7 +291,7 @@ private unsafe static int ReadData(int itemSize, byte* currentPtr, byte* endPtr)`
`291`	`291`	`var data3 = *(currentPtr + 2);`
`292`	`292`	`var data4 = *(currentPtr + 3);`
`293`	`293`
`294`		`- return (data4 << 24) \| (data3 << 24) \| (data2 << 8) \| data1;`
	`294`	`+ return (data4 << 24) \| (data3 << 16) \| (data2 << 8) \| data1;`
`295`	`295`	`}`
`296`	`296`
`297`	`297`	`Debug.Assert(false, "Should not reach here");`