NEW: Added analytics for Input Action Editor Session, Component Editor, Build/Settings (ISX-1546) (#1808)

* Refactored session analytics out of InputAnalytics into InputEditorAnalytics to make a clear cut between mixed and editor only types.

* FIX: Due SettingsProvider bug in Unity focusController may be null due to incorrect function calls to Activate and Deactivate. Hence adding a null check to work around that problem.

* NEW: Added analytics for settings.

* FIX: Variable name shadowing causing compilation failure on Unity 2019.

* FIX: Corrected code to compile correctly when Project-wide Input Actions are not available.

* FIX: Corrected conditional compilation for Unity version supporting Project-wide Input Actions.

* NEW: Added build GUID to build analytics top support group-by

* NEW: Added component editor analytics

* FIX: ISXB-930 InputActionVisualizer and InputControlVisualizer exception on entering play-mode

Author: ekcoh

Assets/Samples/Visualizers/InputActionVisualizer.cs

@@ -63,9 +63,12 @@ protected void Update()
         {
             base.OnDisable();
 
-            s_EnabledInstances.Remove(this);
-            if (s_EnabledInstances.Count == 0)
-                InputSystem.onActionChange -= OnActionChange;
+            if (s_EnabledInstances != null)
+            {
+                s_EnabledInstances.Remove(this);
+                if (s_EnabledInstances.Count == 0)
+                    InputSystem.onActionChange -= OnActionChange;
+            }
 
             if (m_Visualization == Visualization.Interaction && m_Action != null)
             {

Assets/Samples/Visualizers/InputControlVisualizer.cs

@@ -102,11 +102,14 @@ public int controlIndex
             if (m_Visualization == Mode.None)
                 return;
 
-            s_EnabledInstances.Remove(this);
-            if (s_EnabledInstances.Count == 0)
+            if (s_EnabledInstances != null)
             {
-                InputSystem.onDeviceChange -= OnDeviceChange;
-                InputSystem.onEvent -= OnEvent;
+                s_EnabledInstances.Remove(this);
+                if (s_EnabledInstances.Count == 0)
+                {
+                    InputSystem.onDeviceChange -= OnDeviceChange;
+                    InputSystem.onEvent -= OnEvent;
+                }
             }
 
             m_Control = null;

Assets/Tests/InputSystem.Editor/TestData.cs

@@ -4,6 +4,7 @@
 using UnityEngine;
 using UnityEngine.InputSystem;
 using UnityEngine.InputSystem.Editor;
+using InputAnalytics = UnityEngine.InputSystem.InputAnalytics;
 using Random = UnityEngine.Random;
 
 public static class TestData
@@ -33,11 +34,13 @@ public static class TestData
     });
 
     internal static Generator<InputActionsEditorState> editorState =
-        new(() => new InputActionsEditorState(new SerializedObject(ScriptableObject.CreateInstance<InputActionAsset>())));
+        new(() => new InputActionsEditorState(
+            new InputActionsEditorSessionAnalytic(InputActionsEditorSessionAnalytic.Data.Kind.EditorWindow),
+            new SerializedObject(ScriptableObject.CreateInstance<InputActionAsset>())));
 
     internal static Generator<InputActionsEditorState> EditorStateWithAsset(ScriptableObject asset)
     {
-        return new Generator<InputActionsEditorState>(() => new InputActionsEditorState(new SerializedObject(asset)));
+        return new Generator<InputActionsEditorState>(() => new InputActionsEditorState(null, new SerializedObject(asset)));
     }
 
     public static Generator<InputControlScheme.DeviceRequirement> deviceRequirement =

Assets/Tests/InputSystem/CoreTests_Analytics.cs

@@ -35,11 +35,17 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed the UI generation of enum fields when editing interactions of action properties. The new selected value was lost when saving.
 - Fixed the UI generation of custom interactions of action properties when it rely on OnGUI callback. [ISXB-886](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-886).
 - Fixed deletion of last composite part raising an exception. [ISXB-804](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-804)
+- Fixed an issue related to Visualizers sample where exceptions would be thrown by InputActionVisualizer and InputControlVisualizer when entering play-mode if added as components to a new `GameObject`.
 
 ### Added
 - Added additional device information when logging the error due to exceeding the maximum number of events processed
   set by `InputSystem.settings.maxEventsBytesPerUpdate`. This additional information is available in development builds
   only.
+- Fixed deletion of last composite part raising an exception. [ISXB-804](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-804)
+- Expanded editor and build insight analytics to cover ``.inputactions` asset editor usage, `InputSettings` and common component configurations.
+
+### Changed
+- Changed `DualSenseHIDInputReport` from internal to public visibility
 - Added Input Setting option allowing to keep platform-specific scroll wheel input values instead of automatically converting them to a normalized range.
 
 ## [1.8.2] - 2024-04-29