Increase timeout in UIToolKitBaseTestWindow instead

Author: jfreire-unity

Assets/Tests/InputSystem.Editor/InputActionsEditorTests.cs

@@ -16,7 +16,6 @@ internal class InputActionsEditorTests : UIToolkitBaseTestWindow<InputActionsEdi
 {
     #region setup and teardown
     InputActionAsset m_Asset;
-    const double kTimeoutSecs = 10.0;
 
     public override void OneTimeSetUp()
     {
@@ -46,7 +45,7 @@ public override IEnumerator UnitySetup()
 
     #region Helper methods
 
-    IEnumerator WaitForActionMapRename(int index, bool isActive, double timeoutSecs = 10.0)
+    IEnumerator WaitForActionMapRename(int index, bool isActive, double timeoutSecs = kDefaultTimeoutSecs)
     {
         return WaitUntil(() =>
         {
@@ -59,7 +58,7 @@ IEnumerator WaitForActionMapRename(int index, bool isActive, double timeoutSecs
         }, $"WaitForActionMapRename {index} {isActive}", timeoutSecs);
     }
 
-    IEnumerator WaitForActionRename(int index, bool isActive, double timeoutSecs = 10.0)
+    IEnumerator WaitForActionRename(int index, bool isActive, double timeoutSecs = kDefaultTimeoutSecs)
     {
         return WaitUntil(() =>
         {
@@ -128,8 +127,8 @@ public IEnumerator CanRenameActionMap()
 
         // changing the selection triggers a state change, wait for the scheduler to process the frame
         yield return WaitForSchedulerLoop();
-        yield return WaitForNotDirty(kTimeoutSecs);
-        yield return WaitForFocus(m_Window.rootVisualElement.Q("action-maps-list-view"), kTimeoutSecs);
+        yield return WaitForNotDirty();
+        yield return WaitForFocus(m_Window.rootVisualElement.Q("action-maps-list-view"));
 
         // refetch the action map item since the ui may have refreshed.
         actionMapItem = actionMapsContainer.Query<InputActionMapsTreeViewItem>().ToList();
@@ -203,14 +202,14 @@ public IEnumerator CanRenameAction()
 
         // Selection change triggers a state change, wait for the scheduler to process the frame
         yield return WaitForSchedulerLoop();
-        yield return WaitForNotDirty(kTimeoutSecs);
-        yield return WaitForFocus(m_Window.rootVisualElement.Q<TreeView>("actions-tree-view"), kTimeoutSecs);
+        yield return WaitForNotDirty();
+        yield return WaitForFocus(m_Window.rootVisualElement.Q<TreeView>("actions-tree-view"));
 
         // Re-fetch the actions since the UI may have refreshed.
         actionItem = actionContainer.Query<InputActionsTreeViewItem>().ToList();
 
         SimulateClickOn(actionItem[1]);
-        yield return WaitForNotDirty(kTimeoutSecs);
+        yield return WaitForNotDirty();
         // If the item is already focused, don't click again
         if (!actionItem[1].IsFocused)
         {

Assets/Tests/InputSystem.Editor/UIToolkitBaseTestWindow.cs

@@ -15,6 +15,7 @@
 public class UIToolkitBaseTestWindow<T> where T : EditorWindow
 {
     protected T m_Window;
+    protected const double kDefaultTimeoutSecs = 10.0f;
 
     #region setup and teardown
     [OneTimeSetUp]
@@ -124,7 +125,7 @@ protected void SimulateDeleteCommand()
     /// Wait for UI toolkit scheduler to process the frame
     /// </summary>
     /// <param name="timeoutSecs">Maximum time to wait in seconds.</param>
-    protected IEnumerator WaitForSchedulerLoop(double timeoutSecs = 5.0)
+    protected IEnumerator WaitForSchedulerLoop(double timeoutSecs = kDefaultTimeoutSecs)
     {
         bool done = false;
         m_Window.rootVisualElement.schedule.Execute(() => done = true);
@@ -136,7 +137,7 @@ protected IEnumerator WaitForSchedulerLoop(double timeoutSecs = 5.0)
     /// </summary>
     /// <param name="ve">VisualElement to be focused</param>
     /// <param name="timeoutSecs">Maximum time to wait in seconds.</param>
-    protected IEnumerator WaitForFocus(VisualElement ve, double timeoutSecs = 5.0)
+    protected IEnumerator WaitForFocus(VisualElement ve, double timeoutSecs = kDefaultTimeoutSecs)
     {
         return WaitUntil(() => ve.focusController.focusedElement == ve, "WaitForFocus", timeoutSecs);
     }
@@ -145,7 +146,7 @@ protected IEnumerator WaitForFocus(VisualElement ve, double timeoutSecs = 5.0)
     /// Wait for the windows to be not dirty
     /// </summary>
     /// <param name="timeoutSecs">Maximum time to wait in seconds.</param>
-    protected IEnumerator WaitForNotDirty(double timeoutSecs = 5.0)
+    protected IEnumerator WaitForNotDirty(double timeoutSecs = kDefaultTimeoutSecs)
     {
         return WaitUntil(() => m_Window.rootVisualElement.panel.isDirty == false, "WaitForNotDirty", timeoutSecs);
     }
@@ -156,7 +157,7 @@ protected IEnumerator WaitForNotDirty(double timeoutSecs = 5.0)
     /// <param name="action">Lambda to call between frame</param>
     /// <param name="assertMessage">Assert Message</param>
     /// <param name="timeoutSecs">Maximum time to wait in seconds.</param>
-    protected IEnumerator WaitUntil(Func<bool> action, string assertMessage, double timeoutSecs = 5.0)
+    protected IEnumerator WaitUntil(Func<bool> action, string assertMessage, double timeoutSecs = kDefaultTimeoutSecs)
     {
         var endTime = EditorApplication.timeSinceStartup + timeoutSecs;
         do