Add unit tests for testing against warnings that should be shown if actions are missing from the UI action map.

Author: Darren-Kelly-Unity

Assets/Tests/InputSystem/Plugins/InputForUITests.cs

@@ -14,6 +14,7 @@
 using UnityEngine.InputSystem.Editor;
 #endif
 using UnityEngine.InputSystem.Plugins.InputForUI;
+using UnityEngine.InputSystem.Utilities;
 using Event = UnityEngine.InputForUI.Event;
 using EventProvider = UnityEngine.InputForUI.EventProvider;
 using Is = NUnit.Framework.Is;
@@ -535,19 +536,34 @@ public void DefaultActions_ShouldNotGenerateAnyVerificationWarnings(bool useProj
         LogAssert.NoUnexpectedReceived();
     }
 
-    [Ignore("We currently allow a PWA asset without an UI action map and rely on defaults instead. This allows users that do not want it or use something else to avoid using it.")]
-    [Test(Description = "Verifies that user-supplied project-wide input actions generates warnings if action map is missing.")]
+    [Test(Description = "Verifies that user-supplied project-wide actions do not generate warnings if action map is missing. We use default actions in this case.")]
     [Category(kTestCategory)]
-    public void ActionsWithoutUIMap_ShouldGenerateWarnings()
+    public void ActionsWithoutUIMap_ShouldNotGenerateWarnings()
     {
         var asset = ProjectWideActionsAsset.CreateDefaultAssetAtPath(kAssetPath);
         asset.RemoveActionMap(asset.FindActionMap("UI", throwIfNotFound: true));
 
         InputSystem.s_Manager.actions = asset;
         Update();
 
+        LogAssert.NoUnexpectedReceived();
+    }
+    
+    [Test(Description = "Verifies that user-supplied project-wide input actions generates warnings if the UI map is present but actions are missing.")]
+    [Category(kTestCategory)]
+    public void ActionsWithUIMap_MissingActions_ShouldGenerateWarnings()
+    {
+        var asset = ProjectWideActionsAsset.CreateDefaultAssetAtPath(kAssetPath);
+        var uiActionMap = asset.FindActionMap("UI", true);
+        for (int i = uiActionMap.m_Actions.Length - 1; i >= 0; i--)
+        {
+            ArrayHelpers.EraseAt(ref uiActionMap.m_Actions, uiActionMap.m_Actions.Length - 1);
+        }
+
+        InputSystem.s_Manager.actions = asset;
+        Update();
+
         var link = EditorHelpers.GetHyperlink(kAssetPath);
-        LogAssert.Expect(LogType.Warning, new Regex($"^InputActionMap with path 'UI' in asset '{link}' could not be found."));
         if (InputActionAssetVerifier.DefaultReportPolicy == InputActionAssetVerifier.ReportPolicy.ReportAll)
         {
             LogAssert.Expect(LogType.Warning, new Regex($"^InputAction with path 'UI/Point' in asset '{link}' could not be found."));
@@ -559,8 +575,6 @@ public void ActionsWithoutUIMap_ShouldGenerateWarnings()
             LogAssert.Expect(LogType.Warning, new Regex($"^InputAction with path 'UI/RightClick' in asset '{link}' could not be found."));
             LogAssert.Expect(LogType.Warning, new Regex($"^InputAction with path 'UI/ScrollWheel' in asset '{link}' could not be found."));
         }
-        // else: expect suppression of child errors
-        LogAssert.NoUnexpectedReceived();
     }
 
     [Test(Description = "Verifies that user-supplied project-wide input actions generates warnings if any required action is missing.")]