CHANGE: Fix test framework define (#1618)

* Fix test framework define

* changelog

* wrap defines

* use override references

* Revert "wrap defines"

This reverts commit 8bcaaf3.

Co-authored-by: James McGill <[email protected]>

Author: jechter

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -25,6 +25,8 @@ however, it has to be formatted properly to pass verification tests.
 ### Actions
 - Extended input action code generator (`InputActionCodeGenerator.cs`) to support optional registration and unregistration of callbacks for multiple callback instances via `AddCallbacks(...)` and `RemoveCallbacks(...)` part of the generated code. Contribution by [Ramobo](https://github.com/Ramobo) in [#889](https://github.com/Unity-Technologies/InputSystem/pull/889).
 
+### Changed
+- Changed define requirements of `Unity.InputSystem.TestFramework`, so that it can be used by other packages without setting the `com.unity.inputsystem` package to be testable in the project manifest.
 
 ## [1.4.4] - 2022-11-01
 

Packages/com.unity.inputsystem/Tests/TestFixture/Unity.InputSystem.TestFramework.asmdef

@@ -1,17 +1,25 @@
 {
     "name": "Unity.InputSystem.TestFramework",
     "references": [
-        "GUID:75469ad4d38634e559750d17036d5f7c"
-    ],
-    "optionalUnityReferences": [
-        "TestAssemblies"
+        "Unity.InputSystem",
+        "UnityEngine.TestRunner",
+        "UnityEditor.TestRunner"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],
     "allowUnsafeCode": true,
-    "overrideReferences": false,
-    "precompiledReferences": [],
+    "overrideReferences": true,
+    "precompiledReferences": [
+        "nunit.framework.dll"
+    ],
     "autoReferenced": false,
-    "defineConstraints": ["UNITY_INCLUDE_TESTS"],
+    "defineConstraints": ["UNITY_TESTS_FRAMEWORK"],
+    "versionDefines": [
+        {
+            "name": "com.unity.test-framework",
+            "expression": "",
+            "define": "UNITY_TESTS_FRAMEWORK"
+        }
+    ],   
     "versionDefines": []
 }