FIX: Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to IInputAnalytic.TryGatherData not being defined. (#2115)

ekcoh · web-flow · commit fc4ddbe6b804 · 2025-01-29T09:36:45.000+01:00
diff --git a/Packages/com.unity.inputsystem/CHANGELOG.md b/Packages/com.unity.inputsystem/CHANGELOG.md
@@ -15,6 +15,7 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed Cut Mode for Action Maps and Actions to make renaming disabled. [ISXB-1155](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1155)
 - Fixed GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum values not matching displayed dropdown values in editor when using GamepadButtonPropertyDrawer [ISXB-1270](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1270).
 - Fixed an issue causing InvalidOperationException when entering playmode with domain reload disabled. [ISXB-1208](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1208).
+- Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to `IInputAnalytic.TryGatherData` not being defined [ISXB-1203](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1203).
 
 ## [1.12.0] - 2025-01-15
 
diff --git a/Packages/com.unity.inputsystem/InputSystem/InputAnalytics.cs b/Packages/com.unity.inputsystem/InputSystem/InputAnalytics.cs
@@ -47,10 +47,10 @@ public interface IInputAnalytic
         {
             InputAnalyticInfo info { get; } // May be removed when only supporting 2023.2+ versions
 
-#if !UNITY_2023_2_OR_NEWER
+#if !UNITY_EDITOR || !UNITY_2023_2_OR_NEWER
             // Conditionally mimic UnityEngine.Analytics.IAnalytic
             bool TryGatherData(out IInputAnalyticData data, out Exception error);
-#endif // !UNITY_2023_2_OR_NEWER
+#endif // !UNITY_EDITOR || !UNITY_2023_2_OR_NEWER
         }
 
         public static void Initialize(InputManager manager)

Original file line number	Diff line number	Diff line change
`@@ -47,10 +47,10 @@ public interface IInputAnalytic`
`47`	`47`	`{`
`48`	`48`	`InputAnalyticInfo info { get; } // May be removed when only supporting 2023.2+ versions`
`49`	`49`
`50`		`-#if !UNITY_2023_2_OR_NEWER`
	`50`	`+#if !UNITY_EDITOR \|\| !UNITY_2023_2_OR_NEWER`
`51`	`51`	`// Conditionally mimic UnityEngine.Analytics.IAnalytic`
`52`	`52`	`bool TryGatherData(out IInputAnalyticData data, out Exception error);`
`53`		`-#endif // !UNITY_2023_2_OR_NEWER`
	`53`	`+#endif // !UNITY_EDITOR \|\| !UNITY_2023_2_OR_NEWER`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`public static void Initialize(InputManager manager)`