-
Couldn't load subscription status.
- Fork 328
FIX: ISXB-1134 Fix for Action context menu not showing on right-click. #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Packages/com.unity.inputsystem/InputSystem/Editor/UITKAssetEditor/Views/ActionMapsView.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked that ISXB-833 has not been reintroduced, tried adding maps and actions in various ways such as when the list is empty, when selecting different actions and maps, using the plus buttons, after undoing/redoing, etc (22.3.51 and U6 trunk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
Description
Tentative fix for context menu issue in Input Action Editor.
Testing status & QA
Tested context menu when creating new input action asset on 6000.21f and 2022.3 latest LTS. Seem to give expected results.,
Overall Product Risks
One liner, small.
Comments to reviewers
The indirection used for context menus static helpers is confusing, good to have a second look on the change.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: