FIX: Prevent composite parts being pasted into non-composites #2153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to paste a composite part into a non-composite binding both Input Manager and Input System end up throwing errors as it uses a best guess trying to find the closest applicable index it can paste into. When pasting directly into a binding nothing is found, so nothing is pasted, but attempts to return the new selection/last pasted element anyway.
This fix skips returning the new selections when nothing was actually pasted.
I attempted to look into disabling paste completely in this scenario but
HasPastableClipboardDatais passed theInputBindingtype and I couldn't find a simple way to distinguish between composites and bindings at this point.Testing status & QA
Tested in Input Manager and Input System (old and new UI) and confirmed that there are no longer errors in either.
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: