Added more performance warnings

Author: Chman

PostProcessing/Editor/Effects/BloomEditor.cs

@@ -11,7 +11,7 @@ public sealed class BloomEditor : PostProcessEffectEditor<Bloom>
         SerializedParameterOverride m_Diffusion;
         SerializedParameterOverride m_AnamorphicRatio;
         SerializedParameterOverride m_Color;
-        SerializedParameterOverride m_MobileOptimized;
+        SerializedParameterOverride m_FastMode;
 
         SerializedParameterOverride m_DirtTexture;
         SerializedParameterOverride m_DirtIntensity;
@@ -24,8 +24,8 @@ public override void OnEnable()
             m_Diffusion = FindParameterOverride(x => x.diffusion);
             m_AnamorphicRatio = FindParameterOverride(x => x.anamorphicRatio);
             m_Color = FindParameterOverride(x => x.color);
-            m_MobileOptimized = FindParameterOverride(x => x.fastMode);
-            
+            m_FastMode = FindParameterOverride(x => x.fastMode);
+
             m_DirtTexture = FindParameterOverride(x => x.dirtTexture);
             m_DirtIntensity = FindParameterOverride(x => x.dirtIntensity);
         }
@@ -40,7 +40,10 @@ public override void OnInspectorGUI()
             PropertyField(m_Diffusion);
             PropertyField(m_AnamorphicRatio);
             PropertyField(m_Color);
-            PropertyField(m_MobileOptimized);
+            PropertyField(m_FastMode);
+
+            if (m_FastMode.overrideState.boolValue && !m_FastMode.value.boolValue && EditorUtilities.isTargetingConsolesOrMobiles)
+                EditorGUILayout.HelpBox("For performance reasons it is recommended to use Fast Mode on mobile and console platforms.", MessageType.Warning);
 
             EditorGUILayout.Space();
             EditorUtilities.DrawHeaderLabel("Dirtiness");

PostProcessing/Editor/Effects/ChromaticAberrationEditor.cs

@@ -0,0 +1,31 @@
+using UnityEngine.Rendering.PostProcessing;
+
+namespace UnityEditor.Rendering.PostProcessing
+{
+    [PostProcessEditor(typeof(ChromaticAberration))]
+    public sealed class ChromaticAberrationEditor : PostProcessEffectEditor<ChromaticAberration>
+    {
+        SerializedParameterOverride m_SpectralLut;
+        SerializedParameterOverride m_Intensity;
+        SerializedParameterOverride m_FastMode;
+
+        public override void OnEnable()
+        {
+            m_SpectralLut = FindParameterOverride(x => x.spectralLut);
+            m_Intensity = FindParameterOverride(x => x.intensity);
+            m_FastMode = FindParameterOverride(x => x.fastMode);
+        }
+
+        public override void OnInspectorGUI()
+        {
+            base.OnInspectorGUI();
+
+            PropertyField(m_SpectralLut);
+            PropertyField(m_Intensity);
+            PropertyField(m_FastMode);
+
+            if (m_FastMode.overrideState.boolValue && !m_FastMode.value.boolValue && EditorUtilities.isTargetingConsolesOrMobiles)
+                EditorGUILayout.HelpBox("For performance reasons it is recommended to use Fast Mode on mobile and console platforms.", MessageType.Warning);
+        }
+    }
+}

PostProcessing/Editor/Effects/ChromaticAberrationEditor.cs.meta

@@ -24,7 +24,7 @@ public sealed class PostProcessLayerEditor : BaseEditor<PostProcessLayer>
         SerializedProperty m_TaaStationaryBlending;
         SerializedProperty m_TaaMotionBlending;
         SerializedProperty m_SmaaQuality;
-        SerializedProperty m_FxaaMobileOptimized;
+        SerializedProperty m_FxaaFastMode;
         SerializedProperty m_FxaaKeepAlpha;
 
         SerializedProperty m_FogEnabled;
@@ -63,7 +63,7 @@ void OnEnable()
             m_TaaStationaryBlending = FindProperty(x => x.temporalAntialiasing.stationaryBlending);
             m_TaaMotionBlending = FindProperty(x => x.temporalAntialiasing.motionBlending);
             m_SmaaQuality = FindProperty(x => x.subpixelMorphologicalAntialiasing.quality);
-            m_FxaaMobileOptimized = FindProperty(x => x.fastApproximateAntialiasing.fastMode);
+            m_FxaaFastMode = FindProperty(x => x.fastApproximateAntialiasing.fastMode);
             m_FxaaKeepAlpha = FindProperty(x => x.fastApproximateAntialiasing.keepAlpha);
 
             m_FogEnabled = FindProperty(x => x.fog.enabled);
@@ -164,11 +164,17 @@ void DoAntialiasing()
                         EditorGUILayout.HelpBox("SMAA doesn't work with Single-pass stereo rendering.", MessageType.Warning);
 
                     EditorGUILayout.PropertyField(m_SmaaQuality);
+
+                    if (m_SmaaQuality.intValue != (int)SubpixelMorphologicalAntialiasing.Quality.Low && EditorUtilities.isTargetingConsolesOrMobiles)
+                        EditorGUILayout.HelpBox("For performance reasons it is recommended to use Low Quality on mobile and console platforms.", MessageType.Warning);
                 }
                 else if (m_AntialiasingMode.intValue == (int)PostProcessLayer.Antialiasing.FastApproximateAntialiasing)
                 {
-                    EditorGUILayout.PropertyField(m_FxaaMobileOptimized);
+                    EditorGUILayout.PropertyField(m_FxaaFastMode);
                     EditorGUILayout.PropertyField(m_FxaaKeepAlpha);
+
+                    if (!m_FxaaFastMode.boolValue && EditorUtilities.isTargetingConsolesOrMobiles)
+                        EditorGUILayout.HelpBox("For performance reasons it is recommended to use Fast Mode on mobile and console platforms.", MessageType.Warning);
                 }
             }
             EditorGUI.indentLevel--;

PostProcessing/Editor/PostProcessLayerEditor.cs

@@ -14,6 +14,36 @@ public static class EditorUtilities
 
         static PostProcessEffectSettings s_ClipboardContent;
 
+        public static bool isTargetingConsoles
+        {
+            get
+            {
+                var t = EditorUserBuildSettings.activeBuildTarget;
+                return t == BuildTarget.PS4
+                    || t == BuildTarget.XboxOne
+                    || t == BuildTarget.Switch;
+            }
+        }
+
+        public static bool isTargetingMobiles
+        {
+            get
+            {
+                var t = EditorUserBuildSettings.activeBuildTarget;
+                return t == BuildTarget.Android
+                    || t == BuildTarget.iOS
+                    || t == BuildTarget.tvOS
+                    || t == BuildTarget.Tizen
+                    || t == BuildTarget.N3DS
+                    || t == BuildTarget.PSP2;
+            }
+        }
+
+        public static bool isTargetingConsolesOrMobiles
+        {
+            get { return isTargetingConsoles || isTargetingMobiles; }
+        }
+
         static EditorUtilities()
         {
             s_GUIContentCache = new Dictionary<string, GUIContent>();
@@ -209,7 +239,7 @@ public static bool DrawHeader(string title, SerializedProperty group, Serialized
             var e = Event.current;
 
             if (e.type == EventType.MouseDown)
-            {   
+            {
                 if (menuRect.Contains(e.mousePosition))
                 {
                     ShowHeaderContextMenu(new Vector2(menuRect.x, menuRect.yMax), target, resetAction, removeAction);