GC fix in 2018.1 (and potentially previous versions)

`SystemInfo.SupportsRenderTextureFormat()` generates garbage......

Author: Chman

PostProcessing/Runtime/Effects/AmbientOcclusion.cs

@@ -77,9 +77,9 @@ public override bool IsEnabledAndSupported(PostProcessRenderContext context)
             {
 #if UNITY_2017_1_OR_NEWER
                 state &= SystemInfo.supportsComputeShaders
-                      && SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.RFloat)
-                      && SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.RHalf)
-                      && SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.R8);
+                      && RenderTextureFormat.RFloat.IsSupported()
+                      && RenderTextureFormat.RHalf.IsSupported()
+                      && RenderTextureFormat.R8.IsSupported();
 #else
                 state = false;
 #endif

PostProcessing/Runtime/Effects/AutoExposure.cs

@@ -40,7 +40,7 @@ public override bool IsEnabledAndSupported(PostProcessRenderContext context)
         {
             return enabled.value
                 && SystemInfo.supportsComputeShaders
-                && SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.RFloat);
+                && RenderTextureFormat.RFloat.IsSupported();
         }
     }
 
@@ -124,7 +124,7 @@ public override void Render(PostProcessRenderContext context)
                 m_AutoExposurePingPong[context.xrActiveEye] = ++pp % 2;
                 m_CurrentAutoExposure = dst;
             }
-            
+
             cmd.EndSample("AutoExposureLookup");
 
             context.autoExposureTexture = m_CurrentAutoExposure;

PostProcessing/Runtime/Effects/ColorGrading.cs

@@ -544,14 +544,14 @@ static RenderTextureFormat GetLutFormat()
             // Use ARGBHalf if possible, fallback on ARGB2101010 and ARGB32 otherwise
             var format = RenderTextureFormat.ARGBHalf;
 
-            if (!SystemInfo.SupportsRenderTextureFormat(format))
+            if (!format.IsSupported())
             {
                 format = RenderTextureFormat.ARGB2101010;
 
                 // Note that using a log lut in ARGB32 is a *very* bad idea but we need it for
                 // compatibility reasons (else if a platform doesn't support one of the previous
                 // format it'll output a black screen, or worse will segfault on the user).
-                if (!SystemInfo.SupportsRenderTextureFormat(format))
+                if (!format.IsSupported())
                     format = RenderTextureFormat.ARGB32;
             }
 

PostProcessing/Runtime/Effects/DepthOfField.cs

@@ -35,7 +35,7 @@ public override bool IsEnabledAndSupported(PostProcessRenderContext context)
                 && SystemInfo.graphicsShaderLevel >= 35;
         }
     }
-    
+
     // TODO: Look into minimum blur amount in the distance, right now it's lerped until a point
     // TODO: Doesn't play nice with alpha propagation, see if it can be fixed without killing performances
     public sealed class DepthOfFieldRenderer : PostProcessEffectRenderer<DepthOfField>
@@ -81,10 +81,10 @@ public override DepthTextureMode GetCameraFlags()
 
         RenderTextureFormat SelectFormat(RenderTextureFormat primary, RenderTextureFormat secondary)
         {
-            if (SystemInfo.SupportsRenderTextureFormat(primary))
+            if (primary.IsSupported())
                 return primary;
 
-            if (SystemInfo.SupportsRenderTextureFormat(secondary))
+            if (secondary.IsSupported())
                 return secondary;
 
             return RenderTextureFormat.Default;
@@ -159,7 +159,7 @@ public override void Render(PostProcessRenderContext context)
                 float motionBlending = context.temporalAntialiasing.motionBlending;
                 float blend = m_ResetHistory ? 0f : motionBlending; // Handles first frame blending
                 var jitter = context.temporalAntialiasing.jitter;
-                
+
                 sheet.properties.SetVector(ShaderIDs.TaaParams, new Vector3(jitter.x, jitter.y, blend));
 
                 int pp = m_HistoryPingPong[context.xrActiveEye];

PostProcessing/Runtime/Effects/Grain.cs

@@ -24,11 +24,11 @@ public override bool IsEnabledAndSupported(PostProcessRenderContext context)
                 && intensity.value > 0f;
         }
     }
-    
+
     public sealed class GrainRenderer : PostProcessEffectRenderer<Grain>
     {
         RenderTexture m_GrainLookupRT;
-        
+
         const int k_SampleCount = 1024;
         int m_SampleIndex;
 
@@ -63,7 +63,7 @@ public override void Render(PostProcessRenderContext context)
 
                 m_GrainLookupRT.Create();
             }
-            
+
             var sheet = context.propertySheets.Get(context.resources.shaders.grainBaker);
             sheet.properties.Clear();
             sheet.properties.SetFloat(ShaderIDs.Phase, time % 10f);
@@ -82,7 +82,7 @@ public override void Render(PostProcessRenderContext context)
 
         RenderTextureFormat GetLookupFormat()
         {
-            if (SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.ARGBHalf))
+            if (RenderTextureFormat.ARGBHalf.IsSupported())
                 return RenderTextureFormat.ARGBHalf;
 
             return RenderTextureFormat.ARGB32;

PostProcessing/Runtime/Effects/MotionBlur.cs

@@ -22,11 +22,11 @@ public override bool IsEnabledAndSupported(PostProcessRenderContext context)
                 && Application.isPlaying
             #endif
                 && SystemInfo.supportsMotionVectors
-                && SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.RGHalf)
+                && RenderTextureFormat.RGHalf.IsSupported()
                 && !RuntimeUtilities.isVREnabled;
         }
     }
-    
+
     public sealed class MotionBlurRenderer : PostProcessEffectRenderer<MotionBlur>
     {
         enum Pass
@@ -57,7 +57,7 @@ public override void Render(PostProcessRenderContext context)
 
             const float kMaxBlurRadius = 5f;
             var vectorRTFormat = RenderTextureFormat.RGHalf;
-            var packedRTFormat = SystemInfo.SupportsRenderTextureFormat(RenderTextureFormat.ARGB2101010)
+            var packedRTFormat = RenderTextureFormat.ARGB2101010.IsSupported()
                 ? RenderTextureFormat.ARGB2101010
                 : RenderTextureFormat.ARGB32;
 

PostProcessing/Runtime/Utils/TextureFormatUtilities.cs

@@ -1,17 +1,19 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using UnityEngine.Assertions;
 
 namespace UnityEngine.Rendering.PostProcessing
 {
     // Temporary code dump until the texture format refactor goes into trunk...
     public static class TextureFormatUtilities
     {
-        static Dictionary<TextureFormat, RenderTextureFormat> s_FormatMap;
+        static Dictionary<TextureFormat, RenderTextureFormat> s_FormatAliasMap;
+        static Dictionary<int, bool> s_SupportedRenderTextureFormats;
 
         static TextureFormatUtilities()
         {
-            s_FormatMap = new Dictionary<TextureFormat, RenderTextureFormat>
+            s_FormatAliasMap = new Dictionary<TextureFormat, RenderTextureFormat>
             {
                 { TextureFormat.Alpha8, RenderTextureFormat.ARGB32 },
                 { TextureFormat.ARGB4444, RenderTextureFormat.ARGB4444 },
@@ -66,6 +68,17 @@ static TextureFormatUtilities()
                 { TextureFormat.ETC_RGB4_3DS, RenderTextureFormat.ARGB32 },
                 { TextureFormat.ETC_RGBA8_3DS, RenderTextureFormat.ARGB32 }
             };
+
+            // In 2018.1 SystemInfo.SupportsRenderTextureFormat() generates garbage so we need to
+            // cache its calls to avoid that...
+            s_SupportedRenderTextureFormats = new Dictionary<int, bool>();
+            var values = Enum.GetValues(typeof(RenderTextureFormat)).Cast<int>();
+
+            foreach (var format in values)
+            {
+                bool supported = SystemInfo.SupportsRenderTextureFormat((RenderTextureFormat)format);
+                s_SupportedRenderTextureFormats.Add(format, supported);
+            }
         }
 
         public static RenderTextureFormat GetUncompressedRenderTextureFormat(Texture texture)
@@ -80,13 +93,20 @@ public static RenderTextureFormat GetUncompressedRenderTextureFormat(Texture tex
                 var inFormat = ((Texture2D)texture).format;
                 RenderTextureFormat outFormat;
 
-                if (!s_FormatMap.TryGetValue(inFormat, out outFormat))
+                if (!s_FormatAliasMap.TryGetValue(inFormat, out outFormat))
                     throw new NotSupportedException("Texture format not supported");
 
                 return outFormat;
             }
 
             return RenderTextureFormat.Default;
         }
+
+        internal static bool IsSupported(this RenderTextureFormat format)
+        {
+            bool supported;
+            s_SupportedRenderTextureFormats.TryGetValue((int)format, out supported);
+            return supported;
+        }
     }
 }