Skip to content

Remove IsNaN checks from min() and max() #243

@MrUnbelievable92

Description

@MrUnbelievable92
  • horrendous code gen

  • hides NaNs which would otherwise be easily caught while debugging

  • propagates throughout the entire Unity.Mathematics.math library

  • ... while breaking the rule of NaN propagation

  • checking for NaN does neither comply to IEEE754, nor any native SIMD instruction sets, nor any C/C++ library - not even UnityEngine.Mathf

  • if we want to copy HLSL 1:1, at least flush denormals to zero and make it even more expensive ;)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions