code review fixes

-add warning for max earlier than 2017
-add warning for ignoring exit code
-remove iconName from macroscripts
-remove if statement that could prevent menu items being added

Author: vkovec

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -135,8 +135,12 @@ public override void OnInspectorGUI() {
                     ExportSettings.DCCType foundDCC = ExportSettings.DCCType.Maya;
                     var foundDCCPath = TryFindDCC (dccPath, ext, ExportSettings.DCCType.Maya);
                     if (foundDCCPath == null && Application.platform == RuntimePlatform.WindowsEditor) {
-                        foundDCCPath = TryFindDCC (dccPath, ext, ExportSettings.DCCType.Max);
-                        foundDCC = ExportSettings.DCCType.Max;
+                        if (!ExportSettings.IsEarlierThanMax2017 (dccPath)) {
+                            Debug.LogWarning ("Earlier than 3ds Max 2017 is not supported");
+                        } else {
+                            foundDCCPath = TryFindDCC (dccPath, ext, ExportSettings.DCCType.Max);
+                            foundDCC = ExportSettings.DCCType.Max;
+                        }
                     }
                     if (foundDCCPath == null) {
                         Debug.LogError (string.Format ("Could not find supported DCC application at: \"{0}\"", Path.GetDirectoryName (dccPath)));
@@ -344,6 +348,10 @@ private static void FindDCCInstalls() {
 
                 if (product.StartsWith ("3ds max", StringComparison.InvariantCultureIgnoreCase)) {
                     var exePath = string.Format ("{0}/{1}", productDir.FullName.Replace ("\\", "/"), "3dsmax.exe");
+                    if (!IsEarlierThanMax2017 (exePath)) {
+                        Debug.LogWarning ("Earlier than 3ds Max 2017 is not supported");
+                        continue;
+                    }
                     string version = product.Substring ("3ds max ".Length);
                     dccOptionPath.Add (exePath);
                     dccOptionName.Add (GetUniqueName ("3ds Max " + version));
@@ -498,11 +506,11 @@ public static string GetMaxOptionName(string exePath){
             return GetUniqueName (Path.GetFileName(Path.GetDirectoryName (exePath)));
         }
 
-        public static bool IsMax2018OrLater(string exePath){
+        public static bool IsEarlierThanMax2017(string exePath){
             var name = Path.GetFileName (Path.GetDirectoryName (exePath)).ToLower();
             name = name.Replace ("3ds max", "").Trim();
             int version;
-            return int.TryParse (name, out version) && version >= 2018;
+            return int.TryParse (name, out version) && version < 2017;
         }
 
         public static string GetSelectedDCCPath()

Assets/FbxExporters/Editor/InstallIntegration.cs

@@ -534,6 +534,7 @@ public static int InstallMaxPlugin(string maxExe){
 
                 // TODO (UNI-29910): figure out what exactly causes this exit code + how to resolve
                 if(ExitCode == -1073740791){
+                    Debug.LogWarning(string.Format("3ds Max exited with code: {0}, ignoring as this does not affect plugin installation", ExitCode));
                     ExitCode = 0;
                 }
 

Assets/Integrations/Autodesk/max/scripts/UnityFbxForMaxPlugin.ms

@@ -1,5 +1,5 @@
 -- MacroScripts that will perform actions
-macroScript UnityImport category:"Unity" iconName:"UnityIcons/import"
+macroScript UnityImport category:"Unity"
 (
     origObjects = #()
 
@@ -45,7 +45,7 @@ macroScript UnityImport category:"Unity" iconName:"UnityIcons/import"
         callbacks.removeScripts #postImport id:#unityPlugin
     )
 )
-macroScript UnityExport category:"Unity" iconName:"UnityIcons/export"
+macroScript UnityExport category:"Unity"
 (
     fn loadUnityFbxExportSettings = (
         fbxExportSettings = getINISetting (GetMAXIniFile()) "Unity" "UnityFbxExportSettings"
@@ -143,16 +143,14 @@ if (maxVersion())[1] >= 20000 then(
 				)
 			)
 
-			if foundUnityImport == false or foundUnityExport == false then(
-				id = genClassID returnValue:true
-				if menuMan.registerMenuContext id[1] then
-				(
-					global unityImportAction = createUnityImportAction unityImportTitle importMenu
-					global unityExportAction = createUnityExportAction unityExportTitle exportMenu
-					
-					menuMan.updateMenuBar() --update the menu bar
-				)
-			)
+            id = genClassID returnValue:true
+            if menuMan.registerMenuContext id[1] then
+            (
+                global unityImportAction = createUnityImportAction unityImportTitle importMenu
+                global unityExportAction = createUnityExportAction unityExportTitle exportMenu
+                
+                menuMan.updateMenuBar() --update the menu bar
+            )
 		)
 	);
 	setupUnityPluginUI()
@@ -169,7 +167,7 @@ if (maxVersion())[1] >= 20000 then(
 		 )"
 	)
 )
-else(
+else if (maxVersion())[1] == 19000 then (
 	-- for 3ds Max 2017
 
 	global unityMenuName = "Unity"
@@ -213,4 +211,7 @@ else(
 			menuMan.unRegisterMenu unityMenu; \
 		 )"
 	)
+)
+else(
+    print "Warning: Unity Integration not supported for 3ds Max versions earlier than 3ds Max 2017"
 )