[CLEANED] Lint!

Author: AJubrey

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -693,7 +693,7 @@ static string AskMayaVersion(string exePath) {
 
             // Output is like: Maya 2018, Cut Number 201706261615
             // We want the stuff after 'Maya ' and before the comma.
-            // TODO: less brittle! Consider also the mel command "about -version".
+            // (Uni-31601) less brittle! Consider also the mel command "about -version".
             var commaIndex = resultString.IndexOf(',');
             return resultString.Substring(0, commaIndex).Substring("Maya ".Length);
         }

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -236,7 +236,7 @@ void ExportComponentAttributes (MeshInfo mesh, FbxMesh fbxMesh, int[] unmergedTr
                     // set texture coordinates per vertex
                     FbxLayerElementArray fbxElementArray = fbxLayerElement.GetDirectArray ();
 
-                    // TODO: only copy unique UVs into this array, and index appropriately
+                    // (Uni-31596) only copy unique UVs into this array, and index appropriately
                     for (int n = 0; n < mesh.VertexColors.Length; n++) {
                         // Converting to Color from Color32, as Color32 stores the colors
                         // as ints between 0-255, while FbxColor and Color
@@ -289,7 +289,7 @@ static void ExportUVs(FbxMesh fbxMesh, MeshInfo mesh, int[] unmergedTriangles)
                         // set texture coordinates per vertex
                         FbxLayerElementArray fbxElementArray = fbxLayerElement.GetDirectArray ();
 
-                        // TODO: only copy unique UVs into this array, and index appropriately
+                        // (Uni-31596) only copy unique UVs into this array, and index appropriately
                         for (int n = 0; n < uvs[i].Length; n++) {
                             fbxElementArray.Add (new FbxVector2 (uvs[i] [n] [0],
                                 uvs[i] [n] [1]));
@@ -1242,7 +1242,7 @@ public Vector3 [] Normals { get {
                     } }
 
                 /// <summary>
-                /// TODO: Gets the binormals for the vertices.
+                /// Gets the binormals for the vertices.
                 /// </summary>
                 /// <value>The normals.</value>
                 private Vector3[] m_Binormals;
@@ -1270,7 +1270,7 @@ public Vector3 [] Binormals {
                 }
 
                 /// <summary>
-                /// TODO: Gets the tangents for the vertices.
+                /// Gets the tangents for the vertices.
                 /// </summary>
                 /// <value>The tangents.</value>
                 private Vector4[] m_tangents;
@@ -1282,7 +1282,7 @@ public Vector4 [] Tangents { get {
                     } }
 
                 /// <summary>
-                /// TODO: Gets the vertex colors for the vertices.
+                /// Gets the vertex colors for the vertices.
                 /// </summary>
                 /// <value>The vertex colors.</value>
                 private Color32 [] m_vertexColors;

Assets/FbxExporters/Editor/FbxPrefabAutoUpdater.cs

@@ -773,11 +773,11 @@ void ClassifyComponents(Transform newFbx, Transform prefab)
                     // same node), we line up the components in the order they
                     // appear. This never happens in stock Unity, someone must have
                     // added an AssetPostprocessor for it to occur.
-                    // TODO: do something smarter.
+                    // (Uni-31604) do something smarter.
                     //
                     // If the node isn't going to be in the prefab, we don't care
                     // about what components might be on it.
-                    foreach(var name in m_nodesInUpdatedPrefab)
+                    foreach (var name in m_nodesInUpdatedPrefab)
                     {
                         if (!m_new.HasNode(name)) {
                             // It's not in the FBX, so clearly we're not updating any components.
@@ -794,18 +794,12 @@ void ClassifyComponents(Transform newFbx, Transform prefab)
                             List<string> prefabValues = null; // get them only if we need them.
 
                             // If we have multiple identical-type components, match them up by index.
-                            // TODO: match them up to minimize the diff instead.
                             int oldN = oldValues.Count;
                             int newN = newValues.Count;
                             for(int i = 0, n = System.Math.Max(oldN, newN); i < n; ++i) {
                                 if (/* isNew */ i < newN) {
                                     var newValue = newValues[i];
-
-                                    // Special case on Transform: if we reparented
-                                    // this node then always update the transform
-                                    // (UNI-25526). That's because when we do the
-                                    // reparenting, it changes the 'prefabValue' in
-                                    // a complicated way.
+                                    
                                     var isReparentedTransform = (typename == "UnityEngine.Transform"
                                         && m_reparentings.ContainsKey(name));
 

Assets/FbxExporters/Editor/InstallIntegration.cs

@@ -430,8 +430,9 @@ public bool InstallMaya(bool verbose = false)
 
                 if (installed)
                 {
-                    // FIXME: remove this when we support parsing existing .mod files
-                    try {
+                    // (Uni-31606): remove this when we support parsing existing .mod files
+                    try
+                    {
                         if (verbose) { Debug.Log(string.Format("Deleting module file {0}", moduleFilePath)); }
                         System.IO.File.Delete(moduleFilePath);
                         installed = false;
@@ -466,15 +467,7 @@ public bool InstallMaya(bool verbose = false)
             {
                 throw new NotImplementedException();
 
-                // TODO: parse installed .mod file
-
-                // TODO: if maya version not installed add
-
-                // TODO: else check installation path
-
-                // TODO: if installation path different
-
-                // TODO: print message package already installed else where
+                // (Uni-31606)
             }
 
             return SetupUserStartupScript (verbose);

Assets/FbxExporters/Editor/ReviewLastSavedModel.cs

@@ -189,7 +189,7 @@ public static void LastSavedModel ()
                 System.Collections.Generic.List<UnityEngine.SceneManagement.Scene> scenes
                       = new System.Collections.Generic.List<UnityEngine.SceneManagement.Scene> ();
 
-                string desiredSceneName = "";//FbxExporters.EditorTools.ExportSettings.GetTurnTableSceneName ();
+                string desiredSceneName = "";
                 if (string.IsNullOrEmpty (desiredSceneName)) {
                     desiredSceneName = DefaultSceneName;
                 }
@@ -212,7 +212,7 @@ public static void LastSavedModel ()
                 // if turntable scene not added to list of scenes
                 if (!scene.IsValid () || !scene.isLoaded) 
                 {
-                    string scenePath = "";//FbxExporters.EditorTools.ExportSettings.GetTurnTableScenePath ();
+                    string scenePath = "";
                     if (string.IsNullOrEmpty(scenePath)) {
                         // and if for some reason the turntable scene is missing create an empty scene
                         // NOTE: we cannot use NewScene because it will force me to save the modified Untitled scene