Merge pull request #327 from Unity-Technologies/UNI-40130-sprint48-release

UNI-40130 sprint 48 release

Author: vkovec

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -57,8 +57,8 @@ public override void OnInspectorGUI() {
             );
 
             exportSettings.exportMeshNoRenderer = EditorGUILayout.Toggle(
-                new GUIContent("Export Meshes with no Renderers:",
-                    "If unchecked, meshes that don't have renderers won't be exported."),
+                new GUIContent("Export Unrendered:",
+                    "If checked, meshes will be exported even if they don't have a Renderer component."),
                 exportSettings.exportMeshNoRenderer
             );
 

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -2951,29 +2951,18 @@ private void ReplaceFile ()
 			[MenuItem(TimelineClipMenuItemName, false, 31)]
             static void OnClipContextClick(MenuCommand command)
             {
-                // Now that we know we have stuff to export, get the user-desired path.
-                string directory = string.IsNullOrEmpty(LastFilePath)
-                                      ? Application.dataPath
-                                      : System.IO.Path.GetDirectoryName(LastFilePath);
-
-                string title = "Select the folder in which the animation files from the timeline will be exported";
-                string folderPath = EditorUtility.SaveFolderPanel(title, directory, "");
-
-                if (string.IsNullOrEmpty(folderPath))
-                {
-                    return;
-                }
-                Debug.Log(folderPath);
-
                 Object[] selectedObjects = Selection.objects;
 
                 foreach (Object editorClipSelected in selectedObjects)
                 {
-                    ExportSingleEditorClip(editorClipSelected, folderPath);
+                    // export first selected editor clip.
+                    if (ExportSingleEditorClip (editorClipSelected)) {
+                        return;
+                    }
                 }
             }
 
-            public static void ExportSingleEditorClip(Object editorClipSelected, string folderPath)
+            public static bool ExportSingleEditorClip(Object editorClipSelected)
             {
                 if (editorClipSelected.GetType().Name.Contains("EditorClip"))
                 {
@@ -2985,15 +2974,25 @@ public static void ExportSingleEditorClip(Object editorClipSelected, string fold
 					AnimationTrack editorClipAnimationTrack = selClipItemParentTrack as AnimationTrack;
                     GameObject animationTrackGObject = UnityEditor.Timeline.TimelineEditor.playableDirector.GetGenericBinding (editorClipAnimationTrack) as GameObject;
 
-                    ExportSingleTimelineClip(timeLineClip, folderPath, animationTrackGObject);
+                    ExportSingleTimelineClip(timeLineClip, animationTrackGObject);
+                    return true;
                 } 
+                return false;
             }
 
-            public static void ExportSingleTimelineClip(TimelineClip timelineClipSelected, string folderPath, GameObject animationTrackGObject)
+            public static void ExportSingleTimelineClip(TimelineClip timelineClipSelected, GameObject animationTrackGObject, string filePath = null)
             {
-				string filePath = folderPath + "/" + animationTrackGObject.name + "@" + timelineClipSelected.animationClip.name + ".fbx";
-				UnityEngine.Object[] myArray = new UnityEngine.Object[] { animationTrackGObject, timelineClipSelected.animationClip };
-				ExportObjects(filePath, myArray, AnimationExportType.timelineAnimationClip);
+                if (string.IsNullOrEmpty (filePath)) {
+                    filePath = GetExportFilePath (animationTrackGObject.name + "@" + timelineClipSelected.displayName);
+                }
+                if (string.IsNullOrEmpty (filePath)) {
+                    return;
+                }
+                UnityEngine.Object[] myArray = new UnityEngine.Object[] {
+                    animationTrackGObject,
+                    timelineClipSelected.animationClip
+                };
+                ExportObjects (filePath, myArray, AnimationExportType.timelineAnimationClip);
             }
 
             /// <summary>
@@ -3040,8 +3039,6 @@ public static void OnPlayableDirectorGameObjectContextClick(MenuCommand command)
 
             public static void ExportAllTimelineClips(GameObject objectWithPlayableDirector, string folderPath)
             {
-                Debug.Log(objectWithPlayableDirector.GetType().BaseType.ToString() + ":" + objectWithPlayableDirector.name);
-
                 PlayableDirector pd = objectWithPlayableDirector.GetComponent<PlayableDirector>();
                 if (pd != null)
                 {
@@ -3050,13 +3047,12 @@ public static void ExportAllTimelineClips(GameObject objectWithPlayableDirector,
                         AnimationTrack at = output.sourceObject as AnimationTrack;
 
                         GameObject atObject = pd.GetGenericBinding(output.sourceObject) as GameObject;
-			            // One file by animation clip
-			            foreach(TimelineClip timeLineClip in at.GetClips())
-			            {
-				            string filePath = folderPath + "/" + atObject.name + "@" + timeLineClip.animationClip.name + ".fbx";
-				            UnityEngine.Object[] myArray = new UnityEngine.Object[] { atObject, timeLineClip.animationClip };
-				            ExportObjects(filePath, myArray, AnimationExportType.timelineAnimationClip);
-			            }
+                        // One file by animation clip
+                        foreach (TimelineClip timeLineClip in at.GetClips()) {
+                            string filePath = string.Format(AnimFbxFileFormat, folderPath, atObject.name, timeLineClip.displayName);
+                            UnityEngine.Object[] myArray = new UnityEngine.Object[] { atObject, timeLineClip.animationClip };
+                            ExportObjects (filePath, myArray, AnimationExportType.timelineAnimationClip);
+                        }
                     }
                 }
             }
@@ -3633,7 +3629,6 @@ private static void OnExport (AnimationExportType exportType = AnimationExportTy
             /// Export a list of (Game) objects to FBX file. 
             /// Use the SaveFile panel to allow user to enter a file name.
             /// <summary>
-            //public static string ExportObjects (string filePath, UnityEngine.Object[] objects = null, AnimationExportType exportType = AnimationExportType.all /*, bool animOnly = false*/)
             public static string ExportObjects (
                 string filePath,
                 UnityEngine.Object[] objects = null,
@@ -3690,7 +3685,6 @@ public static string ExportObjects (
                 return null;
             }
 
-            //public static string ExportObject (string filePath, UnityEngine.Object root, AnimationExportType exportType = AnimationExportType.all /*, bool animOnly = false*/)
             public static string ExportObject (
                 string filePath, UnityEngine.Object root,
                 AnimationExportType exportType = AnimationExportType.all,

Assets/FbxExporters/Editor/UnitTests/ExportTimelineClipTest.cs

@@ -35,8 +35,9 @@ public void ExportSingleTimelineClipTest()
                     GameObject atObject = pd.GetGenericBinding (output.sourceObject) as GameObject;
                     // One file by animation clip
                     foreach (TimelineClip timeLineClip in at.GetClips()) {
-                        ModelExporter.ExportSingleTimelineClip (timeLineClip, folderPath, atObject);
-                        FileAssert.Exists (string.Format("{0}/{1}@{2}", folderPath, atObject.name, "Recorded.fbx"));
+                        var filePath = string.Format ("{0}/{1}@{2}", folderPath, atObject.name, "Recorded.fbx");
+                        ModelExporter.ExportSingleTimelineClip (timeLineClip, atObject, filePath);
+                        FileAssert.Exists (filePath);
                     }
                 }
             }

Assets/FbxExporters/Editor/UnitTests/ModelExporterTest.cs

@@ -468,6 +468,7 @@ public void TestComponentAttributeExport()
 
             var gameObject = new GameObject ();
             var meshFilter = gameObject.AddComponent<MeshFilter> ();
+            gameObject.AddComponent<MeshRenderer> ();
 
             meshFilter.sharedMesh = mesh;
 

CMakeLists.txt

@@ -23,7 +23,7 @@ endif()
 message(STATUS "Building for ${CMAKE_BUILD_TYPE}")
 
 if (NOT DEFINED PACKAGE_VERSION OR "${PACKAGE_VERSION}" STREQUAL "")
-    set(PACKAGE_VERSION "sprint47")
+    set(PACKAGE_VERSION "sprint48")
 endif()
 message(STATUS "Using Package Version: ${PACKAGE_VERSION}")
 

RELEASE_NOTES.md

@@ -1,5 +1,21 @@
 RELEASE NOTES
 
+**Version**: sprint48
+
+NEW FEATURES
+
+* Export Settings: Added option to export meshes without renderers
+
+If selected, export meshes on GameObjects that have a mesh filter but no mesh renderer (e.g. Colliders).
+
+FIXES
+
+* TimelineClipExport: use EditorClip name instead of AnimationClip name for filename
+* TimelineClipExport: allow user to select filename for export instead of just the folder name
+* FbxExporter: export meshes in model prefab instances as mesh instances in fbx
+* FbxExporter: fix so animating spot angle in Unity animates cone angle in Maya (not penumbra)
+* MayaIntegration: fix so export set names don't contain invalid chars from filenames (e.g. spaces)
+
 **Version**: sprint47
 
 NEW FEATURES