Skip to content

Commit 261e697

Browse files
committed
code revew fixes
- add path to error - fix up tooltip - add ellipsis to Browse - add space between Maya and version
1 parent 3e5a949 commit 261e697

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

Assets/FbxExporters/Editor/FbxExportSettings.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public override void OnInspectorGUI() {
105105
GUILayout.BeginHorizontal ();
106106
GUILayout.Label (new GUIContent (
107107
"Maya Application:",
108-
"Maya location to install plugins to."));
108+
"Select the version of Maya where you would like to install the Unity integration."));
109109

110110
// dropdown to select Maya version to use
111111
var options = ExportSettings.GetMayaOptions();
@@ -270,8 +270,9 @@ private static void FindMayaInstalls() {
270270
if (product.StartsWith("mayalt", StringComparison.InvariantCultureIgnoreCase)) {
271271
continue;
272272
}
273+
string version = product.Substring ("maya".Length);
273274
mayaOptionPath.Add (GetMayaExePath (productDir.FullName.Replace ("\\", "/")));
274-
mayaOptionName.Add (GetUniqueName(product));
275+
mayaOptionName.Add (GetUniqueName("Maya " + version));
275276
}
276277
}
277278

@@ -331,7 +332,7 @@ public static GUIContent[] GetMayaOptions(){
331332
instance.mayaOptionPaths[i]
332333
);
333334
}
334-
optionArray [optionArray.Length - 1] = new GUIContent("Browse");
335+
optionArray [optionArray.Length - 1] = new GUIContent("Browse...");
335336

336337
return optionArray;
337338
}
@@ -345,7 +346,7 @@ public static void AddMayaOption(string newOption){
345346

346347
// get the version
347348
var version = AskMayaVersion(newOption);
348-
instance.mayaOptionNames.Add (GetUniqueName("Maya"+version));
349+
instance.mayaOptionNames.Add (GetUniqueName("Maya "+version));
349350
mayaOptionPaths.Add (newOption);
350351
instance.selectedMayaApp = mayaOptionPaths.Count - 1;
351352
}

Assets/FbxExporters/Editor/InstallIntegration.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ public static bool InstallMaya(bool verbose = false)
245245
string moduleTemplatePath = GetModuleTemplatePath();
246246
if (!System.IO.File.Exists(moduleTemplatePath))
247247
{
248-
Debug.LogError(string.Format("Missing Maya module file"));
248+
Debug.LogError(string.Format("Missing Maya module file at: \"{0}\"", moduleTemplatePath));
249249
return false;
250250
}
251251

0 commit comments

Comments
 (0)