code review fixes

- add comment to GetMayaInstructionPath()
- use !modelGO instead of modelGO == null
- add tests for getting the maya instruction path

Author: vkovec

Assets/FbxExporters/Editor/InstallIntegration.cs

@@ -254,6 +254,11 @@ public static string GetTempSavePath()
             return FbxExporters.Review.TurnTable.TempSavePath.Replace("\\", "/");
         }
 
+        /// <summary>
+        /// Gets the maya instruction path relative to the Assets folder.
+        /// Assets folder is not included in the path.
+        /// </summary>
+        /// <returns>The relative maya instruction path.</returns>
         public static string GetMayaInstructionPath()
         {
             return MAYA_INSTRUCTION_FILENAME;

Assets/FbxExporters/Editor/ReviewLastSavedModel.cs

@@ -138,7 +138,7 @@ private static Bounds GetRendererBounds(GameObject modelGO)
 
             private static void FrameCameraOnModel(GameObject modelGO)
             {
-                if (modelGO == null) {
+                if (!modelGO) {
                     return;
                 }
 
@@ -175,11 +175,11 @@ private static void LoadLastSavedModel ()
                 }
 
                 // focus onto model
-                if (LastModel != null) {
+                if (LastModel) {
                     var model = LastModel as GameObject;
-                    if (model != null) {
+                    if (model) {
                         var turntable = model.transform.parent;
-                        if (turntable != null) {
+                        if (turntable) {
                             var turntableGO = turntable.gameObject;
                             UnityEditor.Selection.objects = new GameObject[]{ turntableGO };
                             FrameCameraOnModel (turntableGO);

Assets/FbxExporters/Editor/UnitTests/IntegrationsTest.cs

@@ -49,6 +49,8 @@ public void BasicTest() {
             LogNonEmptyString("package version", Editor.Integrations.GetPackageVersion());
             LogNonEmptyString("temp path", Editor.Integrations.GetTempSavePath());
             LogNonEmptyString("export settings path", Editor.Integrations.GetExportSettingsPath ());
+            LogNonEmptyString ("instruction path", Editor.Integrations.GetMayaInstructionPath ());
+            LogNonEmptyString ("full instruction path", Editor.Integrations.GetFullMayaInstructionPath ());
 
             // test that the paths don't contain backslashes
             Assert.IsFalse(Editor.Integrations.GetAppPath().Contains("\\"));