refactor if statement into function

for clarity and to remove duplicate code

Author: vkovec

Assets/FbxExporters/Editor/ConvertToModel.cs

@@ -108,18 +108,7 @@ public static GameObject Convert (
             )
             {
                 // Only create the prefab (no FBX export) if we have selected the root of a model prefab instance.
-                // Children of model prefab instances will also have "model prefab instance"
-                // as their prefab type, so it is important that it is the root that is selected.
-                //
-                // e.g. If I have the following hierarchy: 
-                //      Cube
-                //      -- Sphere
-                //
-                // Both the Cube and Sphere will have ModelPrefabInstance as their prefab type.
-                // However, when selecting the Sphere to convert, we don't want to connect it to the
-                // existing FBX but create a new FBX containing just the sphere.
-                PrefabType unityPrefabType = PrefabUtility.GetPrefabType(toConvert);
-                if (unityPrefabType == PrefabType.ModelPrefabInstance && toConvert.Equals(PrefabUtility.FindPrefabRoot(toConvert))) {
+                if(IsModelInstance(toConvert)){
                     // don't re-export fbx
                     // create prefab out of model instance in scene, link to existing fbx
                     var mainAsset = PrefabUtility.GetPrefabParent(toConvert) as GameObject;
@@ -223,6 +212,26 @@ public static void SetupFbxPrefab(GameObject toConvert, GameObject unityMainAsse
                 }
             }
 
+            /// <summary>
+            /// Determines if the given GameObject is a model instance.
+            /// </summary>
+            /// <returns><c>true</c> if go is a model instance; otherwise, <c>false</c>.</returns>
+            /// <param name="go">Go.</param>
+            public static bool IsModelInstance(GameObject go){
+                // Children of model prefab instances will also have "model prefab instance"
+                // as their prefab type, so it is important that it is the root that is selected.
+                //
+                // e.g. If I have the following hierarchy: 
+                //      Cube
+                //      -- Sphere
+                //
+                // Both the Cube and Sphere will have ModelPrefabInstance as their prefab type.
+                // However, when selecting the Sphere to convert, we don't want to connect it to the
+                // existing FBX but create a new FBX containing just the sphere.
+                PrefabType unityPrefabType = PrefabUtility.GetPrefabType(go);
+                return unityPrefabType == PrefabType.ModelPrefabInstance && go.Equals (PrefabUtility.FindPrefabRoot (go));
+            }
+
             /// <summary>
             /// Check if the file exists, and if it does, then increment the name.
             /// e.g. if filename is Sphere.fbx and it already exists, change it to Sphere 1.fbx.

Assets/FbxExporters/Editor/ConvertToPrefabEditorWindow.cs

@@ -34,8 +34,7 @@ protected void SetGameObjectsToConvert(IEnumerable<GameObject> toConvert){
                 if (m_toConvert.Length == 1) {
                     var go = m_toConvert [0];
                     // check if the GameObject is a model instance, use as default filename and path if it is
-                    PrefabType unityPrefabType = PrefabUtility.GetPrefabType(go);
-                    if (unityPrefabType == PrefabType.ModelPrefabInstance && go.Equals (PrefabUtility.FindPrefabRoot (go))) {
+                    if(ConvertToModel.IsModelInstance(go)) {
                         var mainAsset = PrefabUtility.GetPrefabParent (go) as GameObject;
                         var mainAssetRelPath = AssetDatabase.GetAssetPath (mainAsset);
                         // remove Assets/ from beginning of path
@@ -82,18 +81,7 @@ protected override void Export ()
                     }
 
                     // Only create the prefab (no FBX export) if we have selected the root of a model prefab instance.
-                    // Children of model prefab instances will also have "model prefab instance"
-                    // as their prefab type, so it is important that it is the root that is selected.
-                    //
-                    // e.g. If I have the following hierarchy: 
-                    //      Cube
-                    //      -- Sphere
-                    //
-                    // Both the Cube and Sphere will have ModelPrefabInstance as their prefab type.
-                    // However, when selecting the Sphere to convert, we don't want to connect it to the
-                    // existing FBX but create a new FBX containing just the sphere.
-                    PrefabType unityPrefabType = PrefabUtility.GetPrefabType(go);
-                    if (unityPrefabType == PrefabType.ModelPrefabInstance && go.Equals(PrefabUtility.FindPrefabRoot(go))) {
+                    if(ConvertToModel.IsModelInstance(go)) {
                         // don't re-export fbx
                         // create prefab out of model instance in scene, link to existing fbx
                         var mainAsset = PrefabUtility.GetPrefabParent(go) as GameObject;