Skip to content

Commit 355ddd2

Browse files
authored
Merge pull request #458 from Unity-Technologies/markv/inplace-build
build in-place in com.unity.formats.fbx instead of build/install
2 parents 086dc38 + da71282 commit 355ddd2

File tree

94 files changed

+11
-8
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+11
-8
lines changed

.gitignore

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,3 +74,10 @@ TestProjects/FbxTests/Assets/Plugins*
7474
FbxExportSettings.asset
7575
**/ValidationSuiteResults/**
7676
TestProjects/FbxTests/Logs/*
77+
78+
# Generated by build install
79+
com.unity.formats.fbx/Editor/Integrations~/**
80+
com.unity.formats.fbx/CHANGELOG.md
81+
com.unity.formats.fbx/LICENSE.md
82+
com.unity.formats.fbx/package.json
83+

CMakeLists.txt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
cmake_minimum_required (VERSION 3.8)
22

3-
SET(CMAKE_INSTALL_PREFIX "${CMAKE_BINARY_DIR}/install" CACHE PATH "Install path prefix")
3+
SET(CMAKE_INSTALL_PREFIX "${CMAKE_SOURCE_DIR}" CACHE PATH "Install path prefix")
44
MESSAGE(STATUS "CMAKE_INSTALL_PREFIX is: " ${CMAKE_INSTALL_PREFIX})
55

66
project (UnityFbxExporterEditorPackage NONE)
@@ -25,7 +25,7 @@ execute_process(COMMAND ${GIT_EXECUTABLE} config --get remote.origin.url
2525
OUTPUT_VARIABLE PACKAGE_REPO_URL
2626
OUTPUT_STRIP_TRAILING_WHITESPACE)
2727

28-
configure_file(${CMAKE_SOURCE_DIR}/proto.com.unity.formats.fbx/package.json.in ${CMAKE_BINARY_DIR}/package.json @ONLY)
28+
configure_file(${CMAKE_SOURCE_DIR}/package.json.in ${CMAKE_BINARY_DIR}/package.json @ONLY)
2929

3030
###########################################################################
3131
# Zip integrations folder
@@ -78,11 +78,6 @@ add_custom_target(${MAX_INTEGRATION_ZIP_TARGET} ALL DEPENDS ${MAX_INTEGRATION_ZI
7878
############################################################################
7979
# Install project into build folder
8080

81-
install(
82-
DIRECTORY "${CMAKE_SOURCE_DIR}/proto.com.unity.formats.fbx/"
83-
DESTINATION "${CMAKE_INSTALL_PREFIX}/com.unity.formats.fbx"
84-
PATTERN "*.in" EXCLUDE
85-
)
8681
install(
8782
FILES "${CMAKE_BINARY_DIR}/${MAYA_INTEGRATION_ZIP_NAME}" "${CMAKE_BINARY_DIR}/${MAX_INTEGRATION_ZIP_NAME}"
8883
DESTINATION "${CMAKE_INSTALL_PREFIX}/com.unity.formats.fbx/Editor/Integrations~"
@@ -91,3 +86,4 @@ install(
9186
FILES "${CMAKE_SOURCE_DIR}/CHANGELOG.md" "${CMAKE_SOURCE_DIR}/LICENSE.md" "${CMAKE_BINARY_DIR}/package.json"
9287
DESTINATION "${CMAKE_INSTALL_PREFIX}/com.unity.formats.fbx"
9388
)
89+

TestProjects/FbxTests/Packages/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"com.unity.ads": "2.0.8",
44
"com.unity.analytics": "3.2.2",
55
"com.unity.collab-proxy": "1.2.15",
6-
"com.unity.formats.fbx": "file:../../../build/install/com.unity.formats.fbx",
6+
"com.unity.formats.fbx": "file:../../../com.unity.formats.fbx",
77
"com.unity.formats.fbx.tests": "file:../../../com.unity.formats.fbx.tests",
88
"com.unity.package-manager-ui": "2.1.1",
99
"com.unity.package-validation-suite": "0.4.0-preview.13",

0 commit comments

Comments
 (0)