code review fixes

* use test case source to pass fbx files
* allow for UnitTests to be anywhere in assets folder

Author: vkovec

Assets/FbxExporters/Editor/UnitTests/ExporterTestBase.cs

@@ -261,5 +261,21 @@ public static void AssertSameHierarchy (
                 AssertSameHierarchy (expectedChild.gameObject, actualChild.gameObject);
             }
         }
+
+        /// <summary>
+        /// Given the path to a file, find the file relative to
+        /// the UnitTests folder.
+        /// </summary>
+        /// <returns>The path in unit tests.</returns>
+        /// <param name="partialPath">Partial path.</param>
+        protected static string FindPathInUnitTests(string partialPath){
+            foreach (var dir in Directory.GetDirectories(Application.dataPath, "UnitTests", SearchOption.AllDirectories)) {
+                var fullPath = Path.Combine (dir, partialPath);
+                if (File.Exists (fullPath)) {
+                    return FbxExporters.EditorTools.ExportSettings.ConvertToAssetRelativePath (fullPath);
+                }
+            }
+            return null;
+        }
     }
 }

Assets/FbxExporters/Editor/UnitTests/ModelExporterTest.cs

@@ -528,11 +528,26 @@ private void ExportSkinnedMesh(string fileToExport, out SkinnedMeshRenderer orig
             Assert.IsNotNull (exportedSkinnedMesh);
         }
 
-        [Test]
-        public void TestSkinnedMeshExport(){
-            // for now use this cowboy taken from the asset store as the test file
-            // TODO: find a better/simpler test file
-            var fbxPath = "FbxExporters/Editor/UnitTests/Models/Cowboy/cowboyMidPoly(riged).fbx";
+        public class SkinnedMeshTestDataClass
+        {
+            public static System.Collections.IEnumerable TestCases1 {
+                get {
+                    // for now use this cowboy taken from the asset store as the test file
+                    // TODO: find a better/simpler test file
+                    yield return "Models/Cowboy/cowboyMidPoly(riged).fbx";
+                }
+            }
+            public static System.Collections.IEnumerable TestCases2 {
+                get {
+                    yield return "Models/SimpleMan/SimpleMan.fbx";
+                }
+            }
+        }
+
+        [Test, TestCaseSource(typeof(SkinnedMeshTestDataClass), "TestCases1")]
+        public void TestSkinnedMeshExport(string fbxPath){
+            fbxPath = FindPathInUnitTests (fbxPath);
+            Assert.That (fbxPath, Is.Not.Null);
 
             SkinnedMeshRenderer originalSkinnedMesh, exportedSkinnedMesh;
             ExportSkinnedMesh (fbxPath, out originalSkinnedMesh, out exportedSkinnedMesh);
@@ -600,10 +615,10 @@ public void TestSkinnedMeshExport(){
             Assert.IsNotNull (expWeights);
         }
 
-        [Test]
-        public void TestBoneWeightExport()
-        {
-            var fbxPath = "FbxExporters/Editor/UnitTests/Models/SimpleMan/SimpleMan.fbx";
+        [Test, TestCaseSource(typeof(SkinnedMeshTestDataClass), "TestCases2")]
+        public void TestBoneWeightExport(string fbxPath){
+            fbxPath = FindPathInUnitTests (fbxPath);
+            Assert.That (fbxPath, Is.Not.Null);
 
             SkinnedMeshRenderer originalSkinnedMesh, exportedSkinnedMesh;
             ExportSkinnedMesh (fbxPath, out originalSkinnedMesh, out exportedSkinnedMesh);