Skip to content

Commit 3e9598c

Browse files
author
AJubrey
committed
[REMOVED] unused path variable
[ADDED] checks for rotation [CHANGED] tests to be IsTrue instead of AreEqual, so that I can check the rotations with room for minute error
1 parent f402eeb commit 3e9598c

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

Assets/FbxExporters/Editor/UnitTests/FbxPrefabAutoUpdaterTest.cs

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -58,35 +58,43 @@ public void BasicTest ()
5858
[Test]
5959
public void RectTransformTest ()
6060
{
61-
// Get a random directory.
62-
var path = m_fbxPath;
61+
Vector3 scaleForward = new Vector3(1,2,3);
62+
Vector3 positionForward = new Vector3(100, 200, 300);
63+
Vector3 rotationForward = new Vector3(1,2,3);
64+
65+
Vector3 scaleBackward = new Vector3(3, 2, 1);
66+
Vector3 positionBackward = new Vector3(300, 200, 100);
67+
Vector3 rotationBackward = new Vector3(3,2,1);
6368

6469
//Create a hierarchy with a RectTransform
6570
var cube = GameObject.CreatePrimitive(PrimitiveType.Cube);
6671
var capsule = GameObject.CreatePrimitive(PrimitiveType.Capsule);
6772
capsule.AddComponent<RectTransform>();
6873

69-
capsule.GetComponent<RectTransform>().localScale = new Vector3(1,2,3);
70-
capsule.GetComponent<RectTransform>().localPosition = new Vector3(100,200,300);
74+
capsule.GetComponent<RectTransform>().localScale = scaleForward;
75+
capsule.GetComponent<RectTransform>().localPosition = positionForward;
76+
capsule.GetComponent<RectTransform>().localRotation = Quaternion.Euler(rotationForward);
7177

7278
capsule.transform.parent = cube.transform;
7379

74-
string filePath = Application.dataPath + "/cube.fbx";
80+
string filePath = GetRandomFbxFilePath();
7581

7682
//instantiate our hierarchy as a prefab
7783
var oldInstance = ConvertToModel.Convert(cube, fbxFullPath: filePath);
7884
Assert.IsTrue(oldInstance);
7985

80-
Assert.AreEqual(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localScale, new Vector3(1, 2, 3));
81-
Assert.AreEqual(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localPosition, new Vector3(100, 200, 300));
86+
Assert.IsTrue(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localScale == scaleForward);
87+
Assert.IsTrue(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localPosition == positionForward);
88+
Assert.IsTrue(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localRotation == Quaternion.Euler(rotationForward));
8289

8390
//Create an "updated" hierarchy
8491
var cube2 = GameObject.CreatePrimitive(PrimitiveType.Cube);
8592
var capsule2 = GameObject.CreatePrimitive(PrimitiveType.Capsule);
8693
capsule2.AddComponent<RectTransform>();
8794

88-
capsule2.GetComponent<RectTransform>().localScale = new Vector3(3, 2, 1);
89-
capsule2.GetComponent<RectTransform>().localPosition = new Vector3(300, 200, 100);
95+
capsule2.GetComponent<RectTransform>().localScale = scaleBackward;
96+
capsule2.GetComponent<RectTransform>().localPosition = positionBackward;
97+
capsule2.GetComponent<RectTransform>().localRotation = Quaternion.Euler(rotationBackward);
9098

9199
capsule2.transform.parent = cube2.transform;
92100

@@ -95,8 +103,9 @@ public void RectTransformTest ()
95103
FbxExporters.Editor.ModelExporter.ExportObject(filePath, cube2);
96104
AssetDatabase.Refresh();
97105

98-
Assert.AreEqual(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localScale, new Vector3(3,2,1));
99-
Assert.AreEqual(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localPosition, new Vector3(300, 200, 100));
106+
Assert.IsTrue(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localScale == scaleBackward);
107+
Assert.IsTrue(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localPosition == positionBackward);
108+
Assert.IsTrue(oldInstance.transform.GetChild(0).GetComponent<RectTransform>().localRotation == Quaternion.Euler(rotationBackward));
100109

101110
GameObject.DestroyImmediate(cube);
102111
GameObject.DestroyImmediate(cube2);

0 commit comments

Comments
 (0)