Skip to content

Commit 3fa4f16

Browse files
committed
Update visibility to match the recorder.
1 parent 2e56b81 commit 3fa4f16

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorder.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ namespace UnityEditor.Formats.Fbx.Exporter
99
{
1010
class FbxRecorder : GenericRecorder<FbxRecorderSettings>
1111
{
12-
public override void RecordFrame(RecordingSession ctx)
12+
protected override void RecordFrame(RecordingSession ctx)
1313
{
1414

1515
}
1616

17-
public override void EndRecording(RecordingSession session)
17+
protected override void EndRecording(RecordingSession session)
1818
{
1919
var ars = (FbxRecorderSettings)session.settings;
2020

@@ -23,19 +23,19 @@ public override void EndRecording(RecordingSession session)
2323

2424
var aInput = (AnimationInput)input;
2525

26-
if (aInput.gameObjectRecorder == null)
26+
if (aInput.GameObjectRecorder == null)
2727
continue;
2828

2929
var clip = new AnimationClip();
3030

31-
ars.fileNameGenerator.CreateDirectory(session);
31+
ars.FileNameGenerator.CreateDirectory(session);
3232

33-
var absolutePath = FileNameGenerator.SanitizePath(ars.fileNameGenerator.BuildAbsolutePath(session));
33+
var absolutePath = FileNameGenerator.SanitizePath(ars.FileNameGenerator.BuildAbsolutePath(session));
3434
var clipName = absolutePath.Replace(FileNameGenerator.SanitizePath(Application.dataPath), "Assets");
3535

3636
//AssetDatabase.CreateAsset(clip, clipName);
3737
#if UNITY_2018_3_OR_NEWER
38-
aInput.gameObjectRecorder.SaveToClip(clip, ars.frameRate);
38+
aInput.GameObjectRecorder.SaveToClip(clip, ars.FrameRate);
3939
#else
4040
aInput.gameObjectRecorder.SaveToClip(clip);
4141
#endif
@@ -75,7 +75,7 @@ public override void EndRecording(RecordingSession session)
7575
{
7676
Object.DestroyImmediate(animator);
7777
}
78-
aInput.gameObjectRecorder.ResetRecording();
78+
aInput.GameObjectRecorder.ResetRecording();
7979
}
8080
base.EndRecording(session);
8181
}

com.unity.formats.fbx/Editor/Sources/Recorders/FbxRecorder/FbxRecorderSettings.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ public FbxRecorderSettings()
3434
{
3535
var goWildcard = DefaultWildcard.GeneratePattern("GameObject");
3636

37-
fileNameGenerator.AddWildcard(goWildcard, GameObjectNameResolver);
38-
fileNameGenerator.AddWildcard(DefaultWildcard.GeneratePattern("GameObjectScene"), GameObjectSceneNameResolver);
37+
FileNameGenerator.AddWildcard(goWildcard, GameObjectNameResolver);
38+
FileNameGenerator.AddWildcard(DefaultWildcard.GeneratePattern("GameObjectScene"), GameObjectSceneNameResolver);
3939

40-
fileNameGenerator.forceAssetsFolder = false;
41-
fileNameGenerator.root = OutputPath.Root.AssetsFolder;
42-
fileNameGenerator.fileName = "animation_" + goWildcard + "_" + DefaultWildcard.Take;
40+
FileNameGenerator.ForceAssetsFolder = false;
41+
FileNameGenerator.Root = OutputPath.Root.AssetsFolder;
42+
FileNameGenerator.FileName = "animation_" + goWildcard + "_" + DefaultWildcard.Take;
4343
}
4444

4545
string GameObjectNameResolver(RecordingSession session)
@@ -54,7 +54,7 @@ string GameObjectSceneNameResolver(RecordingSession session)
5454
return go != null ? go.scene.name : "None";
5555
}
5656

57-
public override bool isPlatformSupported
57+
public override bool IsPlatformSupported
5858
{
5959
get
6060
{
@@ -64,12 +64,12 @@ public override bool isPlatformSupported
6464
}
6565
}
6666

67-
public override IEnumerable<RecorderInputSettings> inputsSettings
67+
public override IEnumerable<RecorderInputSettings> InputsSettings
6868
{
6969
get { yield return m_AnimationInputSettings; }
7070
}
7171

72-
internal override bool ValidityCheck(List<string> errors)
72+
protected override bool ValidityCheck(List<string> errors)
7373
{
7474
var ok = base.ValidityCheck(errors);
7575

@@ -92,7 +92,7 @@ void OnDestroy()
9292
m_AnimationInputSettings.ClearExposedReference();
9393
}
9494

95-
public override string extension
95+
protected override string Extension
9696
{
9797
get { return "fbx"; }
9898
}

0 commit comments

Comments
 (0)