uni-42394: don't reset transforms when transfering anim

Viktoria pointed out this piece of code; we were resetting the transform to the identity for the path from the root being exported down to the root being animated.

That's made to be bad by the prior commit (and it never quite did what we intended), so I removed that code.

It's still possible to reset transforms when exporting but only via the API right now. Maybe we shouldn't?

Author: Benoit Hudson

Assets/FbxExporters/Editor/FbxExporter.cs

@@ -2236,9 +2236,6 @@ protected int ExportTransformHierarchy(
                 // Use RSrs as the scaling inheritance instead.
                 fbxNode.SetTransformationInheritType (FbxTransform.EInheritType.eInheritRSrs);
 
-                if (TransformShouldBeReset (unityGo.transform)) {
-                    exportType = TransformExportType.Reset;
-                }
                 ExportTransform (unityGo.transform, fbxNode, newCenter, exportType);
 
                 fbxNodeParent.AddChild (fbxNode);
@@ -2287,35 +2284,6 @@ protected int ExportTransformHierarchy(
                 return numObjectsExported;
             }
 
-            /// <summary>
-            /// Checks if the transform should be reset.
-            /// Transform should be reset if animation is being transferred, and this transform
-            /// is either the animation source, destination, or between these nodes.
-            /// </summary>
-            /// <returns><c>true</c>, if transform should be reset, <c>false</c> otherwise.</returns>
-            /// <param name="t">Transform.</param>
-            private bool TransformShouldBeReset(Transform t){
-                var source = ExportOptions.AnimationSource;
-                var dest = ExportOptions.AnimationDest;
-
-                if (!source || !dest || source == dest) {
-                    return false;
-                }
-
-                // don't want to reset destination, if it's a bone this could cause issues with the skinning
-                var curr = dest.parent;
-                while (curr != source && curr != null) {
-                    if (t == curr) {
-                        return true;
-                    }
-                    curr = curr.parent;
-                }
-                if (t == source) {
-                    return true;
-                }
-                return false;
-            }
-
             /// <summary>
             /// Export data containing what to export when
             /// exporting animation only.
@@ -2543,9 +2511,6 @@ private bool ExportGameObjectAndParents(
 
                 // export regular transform if we are not a bone or failed to export as a bone
                 if(!exportedBoneTransform){
-                    if (TransformShouldBeReset (unityGo.transform)) {
-                        exportType = TransformExportType.Reset;
-                    }
                     ExportTransform (unityGo.transform, fbxNode, newCenter, exportType);
                 }