Merge pull request #229 from Unity-Technologies/UNI-31660-app-dropdown-blank-value

UNI-31660 avoid changing dcc app selection before list is modified

Author: vkovec

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -625,15 +625,15 @@ public static GUIContent[] GetDCCOptions(){
                 FindDCCInstalls ();
             }
 
+            // store the selected app
+            var prevSelection = instance.dccOptionPaths[instance.selectedDCCApp];
+
             // remove options that no longer exist
             List<string> pathsToDelete = new List<string>();
             List<string> namesToDelete = new List<string>();
             for(int i = 0; i < instance.dccOptionPaths.Count; i++) {
                 var dccPath = instance.dccOptionPaths [i];
                 if (!File.Exists (dccPath)) {
-                    if (i == instance.selectedDCCApp) {
-                        instance.selectedDCCApp = instance.GetPreferredDCCApp();
-                    }
                     namesToDelete.Add (instance.dccOptionNames [i]);
                     pathsToDelete.Add (dccPath);
                 }
@@ -645,6 +645,13 @@ public static GUIContent[] GetDCCOptions(){
                 instance.dccOptionNames.Remove (str);
             }
 
+            // set the selected DCC app to the previous selection
+            instance.selectedDCCApp = instance.dccOptionPaths.IndexOf (prevSelection);
+            if (instance.selectedDCCApp < 0) {
+                // find preferred app if previous selection no longer exists
+                instance.selectedDCCApp = instance.GetPreferredDCCApp ();
+            }
+
             if (instance.dccOptionPaths.Count <= 0) {
                 instance.selectedDCCApp = 0;
                 return new GUIContent[]{
@@ -659,7 +666,6 @@ public static GUIContent[] GetDCCOptions(){
                     instance.dccOptionPaths[i]
                 );
             }
-
             return optionArray;
         }