Merge pull request #384 from Unity-Technologies/UT-484-last-keyframe-missing-on-anim-export

vkovec · web-flow · commit 530e9af0baec · 2018-05-02T13:01:46.000-04:00
UT-484 make sure no keyframes are ignored when exporting animation curves
diff --git a/Assets/com.unity.formats.fbx/Editor/Scripts/FbxExporter.cs b/Assets/com.unity.formats.fbx/Editor/Scripts/FbxExporter.cs
@@ -1434,8 +1434,8 @@ public static HashSet<float> GetSampleTimes(AnimationCurve[] animCurves, double
                     lastTime = System.Math.Max(lastTime, ac[ac.length-1].time);
                 }
 
-                int firstframe = (int)(firstTime * sampleRate);
-                int lastframe = (int)(lastTime * sampleRate);
+                int firstframe = (int)System.Math.Floor(firstTime * sampleRate);
+                int lastframe = (int)System.Math.Ceiling(lastTime * sampleRate);
                 for (int i = firstframe; i <= lastframe; i++) {
                     keyTimes.Add ((float)(i * fs));
                 }

Original file line number	Diff line number	Diff line change
`@@ -1434,8 +1434,8 @@ public static HashSet<float> GetSampleTimes(AnimationCurve[] animCurves, double`
`1434`	`1434`	`lastTime = System.Math.Max(lastTime, ac[ac.length-1].time);`
`1435`	`1435`	`}`
`1436`	`1436`
`1437`		`- int firstframe = (int)(firstTime * sampleRate);`
`1438`		`- int lastframe = (int)(lastTime * sampleRate);`
	`1437`	`+ int firstframe = (int)System.Math.Floor(firstTime * sampleRate);`
	`1438`	`+ int lastframe = (int)System.Math.Ceiling(lastTime * sampleRate);`
`1439`	`1439`	`for (int i = firstframe; i <= lastframe; i++) {`
`1440`	`1440`	`keyTimes.Add ((float)(i * fs));`
`1441`	`1441`	`}`