updated integration unit tests

+ fixed missing null or empty string check in
"FolderAlreadyUnzippedAtPath"

Author: vkovec

Assets/FbxExporters/Editor/InstallIntegration.cs

@@ -503,6 +503,9 @@ public override int InstallIntegration (string mayaExe)
         /// <param name="path">Path.</param>
         public override bool FolderAlreadyUnzippedAtPath(string path)
         {
+            if (string.IsNullOrEmpty (path)) {
+                return false;
+            }
             return System.IO.File.Exists (System.IO.Path.Combine (path, MODULE_TEMPLATE_PATH));
         }
     }
@@ -726,6 +729,9 @@ public override int InstallIntegration(string maxExe){
         /// <param name="path">Path.</param>
         public override bool FolderAlreadyUnzippedAtPath(string path)
         {
+            if (string.IsNullOrEmpty (path)) {
+                return false;
+            }
             return System.IO.File.Exists (System.IO.Path.Combine (path, MaxIntegration.PluginPath));
         }
     }

Assets/FbxExporters/Editor/UnitTests/IntegrationsTest.cs

@@ -25,27 +25,88 @@ void LogNonEmptyString(string name, string str) {
             Assert.IsFalse(string.IsNullOrEmpty(str));
         }
 
+        /// <summary>
+        /// Checks if the given text contains "mayalt" as one word.
+        /// </summary>
+        /// <param name="text">Text.</param>
+        void ContainsMayaLT(string text){
+            Assert.IsFalse (string.IsNullOrEmpty (text));
+            Assert.IsTrue (text.ToLower ().Contains ("mayalt"));
+        }
+
         [Test]
         public void BasicTest() {
-            Assert.IsFalse(Editor.MayaIntegration.IsHeadlessInstall());
-
-            LogNonEmptyString("module path", Editor.MayaIntegration.GetModulePath());
-            LogNonEmptyString("module template path", Editor.MayaIntegration.GetModuleTemplatePath());
-
-            LogNonEmptyString("app path", Editor.MayaIntegration.GetAppPath());
-            LogNonEmptyString("project path", Editor.MayaIntegration.GetProjectPath());
-            LogNonEmptyString("package path", Editor.MayaIntegration.GetPackagePath());
-            LogNonEmptyString("package version", Editor.MayaIntegration.GetPackageVersion());
-            LogNonEmptyString("temp path", Editor.MayaIntegration.GetTempSavePath());
-            LogNonEmptyString("export settings path", Editor.MayaIntegration.GetExportSettingsPath ());
-            LogNonEmptyString ("instruction path", Editor.MayaIntegration.GetMayaInstructionPath ());
-            LogNonEmptyString ("full instruction path", Editor.MayaIntegration.GetFullMayaInstructionPath ());
-
-            // test that the paths don't contain backslashes
-            Assert.IsFalse(Editor.MayaIntegration.GetAppPath().Contains("\\"));
-            Assert.IsFalse(Editor.MayaIntegration.GetProjectPath().Contains("\\"));
-            Assert.IsFalse(Editor.MayaIntegration.GetTempSavePath().Contains("\\"));
-            Assert.IsFalse(Editor.MayaIntegration.GetExportSettingsPath ().Contains("\\"));
+            // test Maya integration
+           {
+                var mayaIntegration = new Editor.MayaIntegration ();
+
+                LogNonEmptyString ("display name", mayaIntegration.DccDisplayName);
+                LogNonEmptyString ("integration zip path", mayaIntegration.IntegrationZipPath);
+
+                Assert.IsFalse (Editor.MayaIntegration.IsHeadlessInstall ());
+
+                LogNonEmptyString ("module template path", mayaIntegration.GetModuleTemplatePath ());
+                LogNonEmptyString ("app path", Editor.MayaIntegration.GetAppPath ());
+                LogNonEmptyString ("package path", Editor.MayaIntegration.GetPackagePath ());
+                LogNonEmptyString ("temp path", Editor.MayaIntegration.GetTempSavePath ());
+                LogNonEmptyString ("instruction path", Editor.MayaIntegration.GetMayaInstructionPath ());
+                LogNonEmptyString ("full instruction path", Editor.MayaIntegration.GetFullMayaInstructionPath ());
+
+                // make sure the path is absolute
+                Assert.IsTrue (System.IO.Path.IsPathRooted (Editor.MayaIntegration.GetFullMayaInstructionPath ()));
+
+                LogNonEmptyString ("export settings path", mayaIntegration.GetExportSettingsPath ());
+                LogNonEmptyString ("package version", Editor.MayaIntegration.GetPackageVersion ());
+
+                // check if folder is unzipped at invalid paths
+                Assert.IsFalse (mayaIntegration.FolderAlreadyUnzippedAtPath (null));
+                Assert.IsFalse (mayaIntegration.FolderAlreadyUnzippedAtPath (""));
+                Assert.IsFalse (mayaIntegration.FolderAlreadyUnzippedAtPath ("X:/a/b/a/c"));
+
+                // test that the paths don't contain backslashes
+                Assert.IsFalse (Editor.MayaIntegration.GetAppPath ().Contains ("\\"));
+                Assert.IsFalse (Editor.MayaIntegration.GetProjectPath ().Contains ("\\"));
+                Assert.IsFalse (Editor.MayaIntegration.GetTempSavePath ().Contains ("\\"));
+                Assert.IsFalse (mayaIntegration.GetExportSettingsPath ().Contains ("\\"));
+                Assert.IsFalse (Editor.MayaIntegration.GetMayaInstructionPath ().Contains ("\\"));
+                Assert.IsFalse (Editor.MayaIntegration.GetFullMayaInstructionPath ().Contains ("\\"));
+            }
+
+            // test Maya LT integration
+            {
+                var mayaLTIntegration = new Editor.MayaLTIntegration ();
+
+                // make sure that the values we get are for Maya LT since it inherits a lot from Maya Integration
+                Assert.AreEqual ("Maya LT", mayaLTIntegration.DccDisplayName);
+                ContainsMayaLT (mayaLTIntegration.IntegrationZipPath);
+
+                LogNonEmptyString ("import settings path", mayaLTIntegration.GetImportSettingsPath ());
+
+                ContainsMayaLT (mayaLTIntegration.GetModuleTemplatePath ());
+                ContainsMayaLT (mayaLTIntegration.GetExportSettingsPath ());
+
+                // test that the paths don't contain backslashes
+                Assert.IsFalse (mayaLTIntegration.GetExportSettingsPath ().Contains ("\\"));
+                Assert.IsFalse (mayaLTIntegration.GetImportSettingsPath ().Contains ("\\"));
+            }
+
+            // test 3ds Max integration
+            {
+                var maxIntegration = new Editor.MaxIntegration ();
+
+                LogNonEmptyString ("display name", maxIntegration.DccDisplayName);
+                LogNonEmptyString ("integration zip path", maxIntegration.IntegrationZipPath);
+
+                // check getting absolute path
+                var absPath = Editor.MaxIntegration.GetAbsPath ("foo");
+                Assert.IsTrue (System.IO.Path.IsPathRooted (absPath));
+                Assert.IsFalse (absPath.Contains ("\\"));
+
+                // check if folder is unzipped at invalid paths
+                Assert.IsFalse (maxIntegration.FolderAlreadyUnzippedAtPath (null));
+                Assert.IsFalse (maxIntegration.FolderAlreadyUnzippedAtPath (""));
+                Assert.IsFalse (maxIntegration.FolderAlreadyUnzippedAtPath ("X:/a/b/a/c"));
+            }
         }
     }
 }