Skip to content

Commit 6d85d31

Browse files
author
Benoit Hudson
committed
Fix a unit test and document (and test) a behaviour.
1 parent 79daa78 commit 6d85d31

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

Assets/FbxExporters/Editor/UnitTests/ConvertToModelTest.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,24 @@ public void TestStaticHelpers()
2525
{
2626
var tempPath = Path.GetTempPath ();
2727
var basename = Path.GetFileNameWithoutExtension (Path.GetRandomFileName ());
28+
basename = basename + "yo"; // add some non-numeric stuff
2829

29-
var filename1 = basename + " 1.fbx";
30-
var filename2 = Path.Combine(tempPath, basename + " 2.fbx");
30+
var filename1 = basename + ".fbx";
31+
var filename2 = Path.Combine(tempPath, basename + " 1.fbx");
32+
Assert.AreEqual (filename2, ConvertToModel.IncrementFileName (tempPath, filename1));
33+
34+
filename1 = basename + " 1.fbx";
35+
filename2 = Path.Combine(tempPath, basename + " 2.fbx");
3136
Assert.AreEqual (filename2, ConvertToModel.IncrementFileName (tempPath, filename1));
3237

3338
filename1 = basename + "1.fbx";
3439
filename2 = Path.Combine(tempPath, basename + "2.fbx");
3540
Assert.AreEqual (filename2, ConvertToModel.IncrementFileName (tempPath, filename1));
3641

37-
filename1 = basename + "k.fbx";
38-
filename2 = Path.Combine(tempPath, basename + "k 1.fbx");
42+
// UNI-25513 spots this lovely behaviour.
43+
// Maybe we should detect zeroes and use them as padding?
44+
filename1 = basename + "01.fbx";
45+
filename2 = Path.Combine(tempPath, basename + "2.fbx");
3946
Assert.AreEqual (filename2, ConvertToModel.IncrementFileName (tempPath, filename1));
4047
}
4148

0 commit comments

Comments
 (0)