Skip to content

Commit 71c7e85

Browse files
committed
added note about aspect ratio in test
+ added delta to float comparison tests
1 parent 284189b commit 71c7e85

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

Assets/FbxExporters/Editor/UnitTests/ModelExporterTest.cs

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -326,13 +326,17 @@ public void TestExporterCallbacks()
326326

327327
[Test]
328328
public void TestExportCamera(){
329+
// NOTE: even though the aspect ratio is exported,
330+
// it does not get imported back into Unity.
331+
// Therefore don't modify or check if camera.aspect is the same
332+
// after export.
333+
329334
// create a Unity camera
330335
GameObject cameraObj = new GameObject("TestCamera");
331336
Camera camera = cameraObj.AddComponent<Camera> ();
332337

333338
// change some of the default settings
334339
camera.orthographic = false;
335-
camera.aspect = 0.5f;
336340
camera.fieldOfView = 17.5f;
337341
camera.nearClipPlane = 1.2f;
338342
camera.farClipPlane = 1345;
@@ -344,7 +348,6 @@ public void TestExportCamera(){
344348

345349
// test export orthographic camera
346350
camera.orthographic = true;
347-
camera.aspect = 1.2f;
348351
camera.fieldOfView = 78;
349352
camera.nearClipPlane = 19;
350353
camera.farClipPlane = 500.6f;
@@ -370,12 +373,11 @@ private Camera ExportCamera(string filename, GameObject cameraObj){
370373
return fbxCamera;
371374
}
372375

373-
private void CompareCameraValues(Camera camera, Camera fbxCamera){
376+
private void CompareCameraValues(Camera camera, Camera fbxCamera, float delta=0.001f){
374377
Assert.AreEqual (camera.orthographic, fbxCamera.orthographic);
375-
Assert.AreEqual (camera.aspect, fbxCamera.aspect);
376-
Assert.AreEqual (camera.fieldOfView, fbxCamera.fieldOfView);
377-
Assert.AreEqual (camera.nearClipPlane, fbxCamera.nearClipPlane);
378-
Assert.AreEqual (camera.farClipPlane, fbxCamera.farClipPlane);
378+
Assert.AreEqual (camera.fieldOfView, fbxCamera.fieldOfView, delta);
379+
Assert.AreEqual (camera.nearClipPlane, fbxCamera.nearClipPlane, delta);
380+
Assert.AreEqual (camera.farClipPlane, fbxCamera.farClipPlane, delta);
379381
}
380382
}
381383
}

0 commit comments

Comments
 (0)