use selected maya install for installing integration

- also make sure that all names are unique in the dropdown
- serialize the list and dictionary for the dropdown
- get the version of any Maya install that is not found by default

Author: vkovec

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -115,7 +115,11 @@ public override void OnInspectorGUI() {
             int result = EditorGUILayout.Popup(exportSettings.selectedMayaApp, options);
             if (result == options.Length - 1) {
                 string mayaPath = EditorUtility.OpenFilePanel ("Select Maya Application", ExportSettings.kDefaultAdskRoot, "exe");
-                if (!string.IsNullOrEmpty (mayaPath)) {
+
+                // check that the path is valid and references the maya executable
+                if (!string.IsNullOrEmpty (mayaPath) &&
+                    Path.GetFileNameWithoutExtension(mayaPath).ToLower().Equals("maya")
+                ) {
                     ExportSettings.AddMayaOption (mayaPath);
                     Repaint ();
                 }
@@ -183,10 +187,10 @@ public class ExportSettings : ScriptableSingleton<ExportSettings>
         [SerializeField]
         string convertToModelSavePath;
 
-        //[SerializeField]
+        [SerializeField]
         // List of paths in order that they appear in the option list
         private System.Collections.Generic.List<string> mayaOptionPaths;
-        //[SerializeField]
+        [SerializeField]
         // Dictionary of path -> display name
         private System.Collections.Generic.Dictionary<string, string> mayaAppOptions;
 
@@ -200,15 +204,49 @@ protected override void LoadDefaults()
             mayaAppOptions = null;
         }
 
+        /// <summary>
+        /// Increments the name if there is a duplicate in MayaAppOptions dictionary.
+        /// </summary>
+        /// <returns>The unique name.</returns>
+        /// <param name="name">Name.</param>
+        private static string GetUniqueName(string name){
+            if (!instance.mayaAppOptions.ContainsValue (name)) {
+                return name;
+            }
+            var format = "{1} ({0})";
+            int index = 1;
+            // try extracting the current index from the name and incrementing it
+            var result = System.Text.RegularExpressions.Regex.Match(name, @"\((?<number>\d+?)\)$");
+            if (result != null) {
+                var number = result.Groups["number"].Value;
+                int tempIndex;
+                if (int.TryParse (number, out tempIndex)) {
+                    var indexOfNumber = name.LastIndexOf (number);
+                    format = name.Remove (indexOfNumber, number.Length).Insert (indexOfNumber, "{0}");
+                    index = tempIndex+1;
+                }
+            }
+
+            string uniqueName = null;
+            do {
+                uniqueName = string.Format (format, index, name);
+                index++;
+            } while (File.Exists (uniqueName));
+
+            return uniqueName;
+        }
+
         /// <summary>
         /// Find Maya installations at default install path.
         /// Add results to given dictionary.
         /// 
         /// If MAYA_LOCATION is set, add this to the list as well.
         /// </summary>
-        private static System.Collections.Generic.Dictionary<string, string> FindMayaInstalls() {
-            System.Collections.Generic.Dictionary<string, string> mayaAppOptions = 
-                new System.Collections.Generic.Dictionary<string, string> ();
+        private static void FindMayaInstalls() {
+            if (instance.mayaAppOptions == null) {
+                instance.mayaAppOptions = new System.Collections.Generic.Dictionary<string, string> ();
+            }
+            var mayaAppOptions = instance.mayaAppOptions;
 
             // If the location is given by the environment, use it.
             var location = System.Environment.GetEnvironmentVariable ("MAYA_LOCATION");
@@ -231,9 +269,8 @@ private static System.Collections.Generic.Dictionary<string, string> FindMayaIns
                 if (product.StartsWith("mayalt", StringComparison.InvariantCultureIgnoreCase)) {
                     continue;
                 }
-                mayaAppOptions.Add (GetMayaExePath(productDir.FullName.Replace("\\","/")), product);
+                mayaAppOptions.Add (GetMayaExePath(productDir.FullName.Replace("\\","/")), GetUniqueName(product));
             }
-            return mayaAppOptions;
         }
 
         /// <summary>
@@ -264,7 +301,7 @@ private static string GetMayaExePath(string location)
 
         public static GUIContent[] GetMayaOptions(){
             if (instance.mayaAppOptions == null) {
-                instance.mayaAppOptions = FindMayaInstalls ();
+                FindMayaInstalls ();
                 instance.mayaOptionPaths = new System.Collections.Generic.List<string> ();
                 foreach (var key in instance.mayaAppOptions.Keys) {
                     instance.mayaOptionPaths.Add (key);
@@ -288,11 +325,42 @@ public static void AddMayaOption(string newOption){
                 instance.selectedMayaApp = instance.mayaOptionPaths.IndexOf (newOption);
                 return;
             }
-            mayaAppOptions.Add (newOption, "Custom Maya Location");
+
+            // get the version
+            var version = AskMayaVersion(newOption);
+            mayaAppOptions.Add (newOption, GetUniqueName("Maya"+version));
             instance.mayaOptionPaths.Add (newOption);
             instance.selectedMayaApp = instance.mayaOptionPaths.Count - 1;
         }
 
+        /// <summary>
+        /// Ask the version number by running maya.
+        /// </summary>
+        static string AskMayaVersion(string exePath) {
+            System.Diagnostics.Process myProcess = new System.Diagnostics.Process();
+            myProcess.StartInfo.FileName = exePath;
+            myProcess.StartInfo.WindowStyle = System.Diagnostics.ProcessWindowStyle.Hidden;
+            myProcess.StartInfo.CreateNoWindow = true;
+            myProcess.StartInfo.UseShellExecute = false;
+            myProcess.StartInfo.RedirectStandardOutput = true;
+            myProcess.StartInfo.Arguments = "-v";
+            myProcess.EnableRaisingEvents = true;
+            myProcess.Start();
+            string resultString = myProcess.StandardOutput.ReadToEnd();
+            myProcess.WaitForExit();
+
+            // Output is like: Maya 2018, Cut Number 201706261615
+            // We want the stuff after 'Maya ' and before the comma.
+            // TODO: less brittle! Consider also the mel command "about -version".
+            var commaIndex = resultString.IndexOf(',');
+            return resultString.Substring(0, commaIndex).Substring("Maya ".Length);
+        }
+
+        public static string GetSelectedMayaPath()
+        {
+            return instance.mayaOptionPaths [instance.selectedMayaApp];
+        }
+
         public static string GetTurnTableSceneName(){
             if (instance.turntableScene) {
                 return instance.turntableScene.name;

Assets/FbxExporters/Editor/InstallIntegration.cs

@@ -334,46 +334,11 @@ public static bool InstallMaya(bool verbose = false)
 
     class IntegrationsUI
     {
-        /// <summary>
-        /// The path where all the different versions of Maya are installed
-        /// by default. Depends on the platform.
-        /// </summary>
-        public const string DefaultAdskRoot =
-#if UNITY_EDITOR_OSX
-            "/Applications/Autodesk"
-#elif UNITY_EDITOR_LINUX
-            "/usr/autodesk"
-#else // WINDOWS
-            "C:/Program Files/Autodesk"
-#endif
-            ;
-
         /// <summary>
         /// The path of the Maya executable.
         /// </summary>
         public static string GetMayaExe () {
-            var location = EditorUtility.OpenFolderPanel ("Select Maya Root Folder", DefaultAdskRoot, "");
-            if (string.IsNullOrEmpty(location)) {
-                return null;
-            }
-
-#if UNITY_EDITOR_OSX
-                // MAYA_LOCATION on mac is set by Autodesk to be the
-                // Contents directory. But let's make it easier on people
-                // and allow just having it be the app bundle or a
-                // directory that holds the app bundle.
-                if (location.EndsWith(".app/Contents")) {
-                return location + "/MacOS/Maya";
-                } else if (location.EndsWith(".app")) {
-                return location + "/Contents/MacOS/Maya";
-                } else {
-                return location + "/Maya.app/Contents/MacOS/Maya";
-                }
-#elif UNITY_EDITOR_LINUX
-                return location + "/bin/maya";
-#else // WINDOWS
-                return location + "/bin/maya.exe";
-#endif
+            return FbxExporters.EditorTools.ExportSettings.GetSelectedMayaPath ();
         }
 
         public static void InstallMayaIntegration ()

Assets/FbxExporters/Editor/UnitTests/IntegrationsTest.cs

@@ -27,9 +27,6 @@ void LogNonEmptyString(string name, string str) {
 
         [Test]
         public void BasicTest() {
-            // Note: This test assumes that Maya is actually installed in a default location.
-            Assert.IsTrue(Directory.Exists(Editor.IntegrationsUI.DefaultAdskRoot));
-
             Assert.IsFalse(Editor.Integrations.IsHeadlessInstall());
 
             LogNonEmptyString("module path", Editor.Integrations.GetModulePath());