Skip to content

Commit 889ce02

Browse files
author
Mark Visser
committed
fix for test failures on trunk
- removed asset with degenerate polygons from test (generated warning which is a no-no) - updated to test with trunk - clear static callbacks in test TearDown to prevent test failure on subsequent runs - fixed platform settings for Unity.Formats.Fbx.Runtime - removed licensetype/time from meta files
1 parent e2136d0 commit 889ce02

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+71
-2872
lines changed

TestProjects/FbxTests/ProjectSettings/ProjectSettings.asset

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
--- !u!129 &1
44
PlayerSettings:
55
m_ObjectHideFlags: 0
6-
serializedVersion: 15
6+
serializedVersion: 16
77
productGUID: dd54005cae86b4618b76f3d9f4829df6
88
AndroidProfiler: 0
99
AndroidFilterTouchesWhenObscured: 0
@@ -68,7 +68,7 @@ PlayerSettings:
6868
androidBlitType: 0
6969
defaultIsNativeResolution: 1
7070
macRetinaSupport: 1
71-
runInBackground: 0
71+
runInBackground: 1
7272
captureSingleScreen: 0
7373
muteOtherAudioSources: 0
7474
Prepare IOS For Recording: 0
@@ -106,6 +106,11 @@ PlayerSettings:
106106
xboxOneDisableEsram: 0
107107
xboxOnePresentImmediateThreshold: 0
108108
switchQueueCommandMemory: 0
109+
switchQueueControlMemory: 16384
110+
switchQueueComputeMemory: 262144
111+
switchNVNShaderPoolsGranularity: 33554432
112+
switchNVNDefaultPoolsGranularity: 16777216
113+
switchNVNOtherPoolsGranularity: 16777216
109114
vulkanEnableSetSRGBWrite: 0
110115
m_SupportedAspectRatios:
111116
4:3: 1
@@ -120,7 +125,6 @@ PlayerSettings:
120125
m_HolographicPauseOnTrackingLoss: 1
121126
xboxOneDisableKinectGpuReservation: 0
122127
xboxOneEnable7thCore: 1
123-
isWsaHolographicRemotingEnabled: 0
124128
vrSettings:
125129
cardboard:
126130
depthFormat: 0
@@ -135,10 +139,17 @@ PlayerSettings:
135139
hololens:
136140
depthFormat: 1
137141
depthBufferSharingEnabled: 0
142+
lumin:
143+
depthFormat: 0
144+
frameTiming: 2
145+
enableGLCache: 0
146+
glCacheMaxBlobSize: 524288
147+
glCacheMaxFileSize: 8388608
138148
oculus:
139149
sharedDepthBuffer: 0
140150
dashSupport: 0
141151
enable360StereoCapture: 0
152+
isWsaHolographicRemotingEnabled: 0
142153
protectGraphicsMemory: 0
143154
enableFrameTimingStats: 0
144155
useHDRDisplay: 0
@@ -187,6 +198,10 @@ PlayerSettings:
187198
iPadHighResPortraitSplashScreen: {fileID: 0}
188199
iPadLandscapeSplashScreen: {fileID: 0}
189200
iPadHighResLandscapeSplashScreen: {fileID: 0}
201+
iPhone65inPortraitSplashScreen: {fileID: 0}
202+
iPhone65inLandscapeSplashScreen: {fileID: 0}
203+
iPhone61inPortraitSplashScreen: {fileID: 0}
204+
iPhone61inLandscapeSplashScreen: {fileID: 0}
190205
appleTVSplashScreen: {fileID: 0}
191206
appleTVSplashScreen2x: {fileID: 0}
192207
tvOSSmallIconLayers: []
@@ -230,26 +245,30 @@ PlayerSettings:
230245
tvOSManualSigningProvisioningProfileType: 0
231246
appleEnableAutomaticSigning: 0
232247
iOSRequireARKit: 0
248+
iOSAutomaticallyDetectAndAddCapabilities: 1
233249
appleEnableProMotion: 0
234250
clonedFromGUID: 00000000000000000000000000000000
235251
templatePackageId:
236252
templateDefaultScene:
237253
AndroidTargetArchitectures: 1
238254
AndroidSplashScreenScale: 0
239255
androidSplashScreen: {fileID: 0}
240-
AndroidKeystoreName:
256+
AndroidKeystoreName: '{inproject}: '
241257
AndroidKeyaliasName:
242258
AndroidBuildApkPerCpuArchitecture: 0
243259
AndroidTVCompatibility: 1
244260
AndroidIsGame: 1
245261
AndroidEnableTango: 0
246262
androidEnableBanner: 1
247263
androidUseLowAccuracyLocation: 0
264+
androidUseCustomKeystore: 0
248265
m_AndroidBanners:
249266
- width: 320
250267
height: 180
251268
banner: {fileID: 0}
252269
androidGamepadSupportLevel: 0
270+
AndroidValidateAppBundleSize: 1
271+
AndroidAppBundleSizeToValidate: 100
253272
resolutionDialogBanner: {fileID: 0}
254273
m_BuildTargetIcons: []
255274
m_BuildTargetPlatformIcons: []
@@ -259,6 +278,7 @@ PlayerSettings:
259278
m_BuildTargetEnableVuforiaSettings: []
260279
openGLRequireES31: 0
261280
openGLRequireES31AEP: 0
281+
openGLRequireES32: 0
262282
m_TemplateCustomTags: {}
263283
mobileMTRendering:
264284
Android: 1
@@ -388,6 +408,7 @@ PlayerSettings:
388408
switchAllowsRuntimeAddOnContentInstall: 0
389409
switchDataLossConfirmation: 0
390410
switchUserAccountLockEnabled: 0
411+
switchSystemResourceMemory: 16777216
391412
switchSupportedNpadStyles: 3
392413
switchNativeFsCacheSize: 32
393414
switchIsHoldTypeHorizontal: 0
@@ -441,6 +462,7 @@ PlayerSettings:
441462
ps4DownloadDataSize: 0
442463
ps4GarlicHeapSize: 2048
443464
ps4ProGarlicHeapSize: 2560
465+
playerPrefsMaxSize: 32768
444466
ps4Passcode: 5PN2qmWqBlQ9wQj99nsQzldVI5ZuGXbE
445467
ps4pnSessions: 1
446468
ps4pnPresence: 1
@@ -488,6 +510,7 @@ PlayerSettings:
488510
webGLCompressionFormat: 1
489511
webGLLinkerTarget: 1
490512
webGLThreadsSupport: 0
513+
webGLWasmStreaming: 0
491514
scriptingDefineSymbols: {}
492515
platformArchitecture: {}
493516
scriptingBackend: {}
@@ -497,6 +520,8 @@ PlayerSettings:
497520
allowUnsafeCode: 0
498521
additionalIl2CppArgs:
499522
scriptingRuntimeVersion: 1
523+
gcIncremental: 0
524+
gcWBarrierValidation: 0
500525
apiCompatibilityLevelPerPlatform: {}
501526
m_RenderingPath: 1
502527
m_MobileRenderingPath: 1
@@ -527,7 +552,6 @@ PlayerSettings:
527552
metroFTAName:
528553
metroFTAFileTypes: []
529554
metroProtocolName:
530-
metroCompilationOverrides: 1
531555
XboxOneProductId:
532556
XboxOneUpdateKey:
533557
XboxOneSandboxId:
@@ -552,7 +576,7 @@ PlayerSettings:
552576
XboxOneAllowedProductIds: []
553577
XboxOnePersistentLocalStorageSize: 0
554578
XboxOneXTitleMemory: 8
555-
xboxOneScriptCompiler: 0
579+
xboxOneScriptCompiler: 1
556580
XboxOneOverrideIdentityName:
557581
vrEditorSettings:
558582
daydream:
@@ -565,7 +589,7 @@ PlayerSettings:
565589
m_PortalFolderPath:
566590
luminCert:
567591
m_CertPath:
568-
m_PrivateKeyPath:
592+
m_SignPackage: 1
569593
luminIsChannelApp: 0
570594
luminVersion:
571595
m_VersionCode: 1
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
m_EditorVersion: 2019.1.0b1
2-
m_EditorVersionWithRevision: 2019.1.0b1 (83b3ba1f99df)
1+
m_EditorVersion: 2019.2.0a5
2+
m_EditorVersionWithRevision: 2019.2.0a5 (5ee2646333c0)

com.unity.formats.fbx.tests/Tests/FbxTests/ModelExporterTest.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using Autodesk.Fbx;
77
using UnityEngine.Formats.Fbx.Exporter;
88
using UnityEditor.Formats.Fbx.Exporter;
9+
using UnityEditor.SceneManagement;
910

1011
namespace FbxExporter.UnitTests
1112
{
@@ -17,6 +18,8 @@ public override void Term ()
1718
#if (!DEBUG_UNITTEST)
1819
base.Term ();
1920
#endif
21+
ModelExporter.UnRegisterAllMeshCallbacks();
22+
ModelExporter.UnRegisterAllMeshObjectCallbacks();
2023
}
2124

2225
[Test]
@@ -261,19 +264,19 @@ public void TestExporterCallbacks()
261264

262265
// Unregister once => only one call per object, and no more for the prefab.
263266
ModelExporter.UnRegisterMeshCallback<FbxPrefab>();
264-
ModelExporter.UnRegisterMeshCallback(tester.CallbackForObject);
267+
ModelExporter.UnRegisterMeshObjectCallback(tester.CallbackForObject);
265268
tester.Verify(0, n);
266269

267270
// Legal to unregister if already unregistered.
268271
ModelExporter.UnRegisterMeshCallback<FbxPrefab>();
269272
tester.Verify(0, n);
270273

271274
// Register same callback twice gets back to original state.
272-
ModelExporter.UnRegisterMeshCallback(tester.CallbackForObject);
275+
ModelExporter.UnRegisterMeshObjectCallback(tester.CallbackForObject);
273276
tester.Verify(0, 0);
274277

275278
// Legal to unregister if already unregistered.
276-
ModelExporter.UnRegisterMeshCallback(tester.CallbackForObject);
279+
ModelExporter.UnRegisterMeshObjectCallback(tester.CallbackForObject);
277280
tester.Verify(0, 0);
278281

279282
///////////////////////
@@ -321,7 +324,7 @@ public void TestExporterCallbacks()
321324
};
322325
ModelExporter.RegisterMeshObjectCallback(callback);
323326
ModelExporter.ExportObject(filename, tree);
324-
ModelExporter.UnRegisterMeshCallback(callback);
327+
ModelExporter.UnRegisterMeshObjectCallback(callback);
325328

326329
asset = AssetDatabase.LoadMainAssetAtPath(filename) as GameObject;
327330
assetMesh = asset.transform.Find("Parent1").GetComponent<MeshFilter>().sharedMesh;
@@ -588,7 +591,6 @@ public static System.Collections.IEnumerable SkinnedMeshCases {
588591
yield return "Models/MultiRootCharacters/NullsInHierarchy.fbx";
589592
// Characters from the asset store
590593
yield return "Models/SimpleMan/SimpleMan.fbx";
591-
yield return "Models/Cowboy/cowboyMidPoly(riged).fbx";
592594
}
593595
}
594596
}

com.unity.formats.fbx.tests/Tests/Models/Cowboy.meta

Lines changed: 0 additions & 8 deletions
This file was deleted.
Binary file not shown.

com.unity.formats.fbx.tests/Tests/Models/Cowboy/BodyMGO.png.meta

Lines changed: 0 additions & 88 deletions
This file was deleted.
Binary file not shown.

0 commit comments

Comments
 (0)