[ADDED] a test to demonstrate purely the preference system at work

[CHANGED] replaced two for loops with two lambda functions
[ADDED] a helper function that just applys a regular expression to a string

Author: AJubrey

Assets/FbxExporters/Editor/FbxExportSettings.cs

@@ -450,38 +450,18 @@ private int ChoosePreferredDCCApp(int optionA, int optionB)
             int scoreA = -1;
             int scoreB = -1;
 
-            for( int i = 0; i < s_PreferenceList.Count; i++ )
-            {
-                //The constant without any spaces
-                string currentApp = System.Text.RegularExpressions.Regex.Replace(s_PreferenceList[i], @"[\s^0-9]", "");
-                //The potential app, without any numbers or spaces
-                string comparingApp = System.Text.RegularExpressions.Regex.Replace(appA, @"[\s^0-9]", "");
-
-                if (currentApp.Equals(comparingApp))
-                {
-                    scoreA = i;
-                    break;
-                }
-                
-            }
+            scoreA = s_PreferenceList.FindIndex(app => RemoveSpacesAndNumbers(app).Equals(RemoveSpacesAndNumbers(appA)));
 
-            for (int i = 0; i < s_PreferenceList.Count; i++)
-            {
-                //The constant without any spaces
-                string currentApp = System.Text.RegularExpressions.Regex.Replace(s_PreferenceList[i], @"[\s^0-9]", "");
-                //The potential app, without any numbers or spaces
-                string comparingApp = System.Text.RegularExpressions.Regex.Replace(appB, @"[\s^0-9]", "");
-
-                if (currentApp.Equals(comparingApp))
-                {
-                    scoreB = i;
-                    break;
-                }
-            }
+            scoreB = s_PreferenceList.FindIndex(app => RemoveSpacesAndNumbers(app).Equals(RemoveSpacesAndNumbers(appB)));
 
             return scoreA < scoreB ? optionA : optionB;
         }
 
+        public string RemoveSpacesAndNumbers(string s)
+        {
+            return System.Text.RegularExpressions.Regex.Replace(s, @"[\s^0-9]", "");
+        }
+
         /// <summary>
         /// Finds the version based off of the title of the application
         /// </summary>

Assets/FbxExporters/Editor/UnitTests/FbxExportSettingsTest.cs

@@ -213,7 +213,7 @@ public void TestFindPreferredProgram()
             Assert.AreEqual(preferred, -1);
 
             //Testing the results of only having a mayaLT install
-            ExportSettings.instance.SetDCCOptionNames(new List<string> { "Maya LT"+ "2018" }); //hardcoded because the constant is changed in another branch but not this one at this time
+            ExportSettings.instance.SetDCCOptionNames(new List<string> { ExportSettings.kMayaLtOptionName + "2018" }); //hardcoded because the constant is changed in another branch but not this one at this time
             preferred = ExportSettings.instance.GetPreferredDCCApp();
 
             Assert.AreEqual(preferred, 0);
@@ -229,6 +229,12 @@ public void TestFindPreferredProgram()
             preferred = ExportSettings.instance.GetPreferredDCCApp();
 
             Assert.AreEqual(preferred, 0);
+
+            //Testing the preference priority
+            ExportSettings.instance.SetDCCOptionNames(new List<string> { ExportSettings.kMaxOptionName + "2018", ExportSettings.kMayaOptionName + "2018", ExportSettings.kMayaLtOptionName + "2018" });
+            preferred = ExportSettings.instance.GetPreferredDCCApp();
+
+            Assert.AreEqual(preferred, 1);
         }
 
         [Test]