small warning fixes

- add properties to fields in structs
- make a couple of functions properties
- move preset selector receiver delegates outside of class
- move FbxPrefabException out of FbxPrefabAutoUpdater

Author: vkovec

Packages/com.unity.formats.fbx/Editor/Scripts/FbxExportPresetSelectorReceiver.cs

@@ -3,15 +3,15 @@
 
 namespace UnityEditor.Formats.Fbx.Exporter
 {
+    public delegate void SelectionChangedDelegate();
+    public delegate void DialogClosedDelegate();
+
     public class FbxExportPresetSelectorReceiver : PresetSelectorReceiver
     {
         UnityEngine.Object m_Target;
         Preset m_InitialValue;
-
-        public delegate void SelectionChangedDelegate();
+        
         public event SelectionChangedDelegate SelectionChanged;
-
-        public delegate void DialogClosedDelegate();
         public event DialogClosedDelegate DialogClosed;
 
         public override void OnSelectionClosed(Preset selection)

Packages/com.unity.formats.fbx/Editor/Scripts/FbxExportSettings.cs

@@ -148,7 +148,7 @@ public override void OnInspectorGUI() {
 
             if (GUILayout.Button (repairMissingScripts)) {
                 var componentUpdater = new UnityEditor.Formats.Fbx.Exporter.RepairMissingScripts ();
-                var filesToRepairCount = componentUpdater.GetAssetsToRepairCount ();
+                var filesToRepairCount = componentUpdater.AssetsToRepairCount;
                 var dialogTitle = "FBX Prefab Component Updater";
                 if (filesToRepairCount > 0) {
                     bool result = UnityEditor.EditorUtility.DisplayDialog (dialogTitle,

Packages/com.unity.formats.fbx/Editor/Scripts/FbxExporter.cs

@@ -1432,13 +1432,24 @@ protected bool ExportCommonConstraintProperties<TUnityConstraint,TFbxConstraint>
 
         protected struct ExpConstraintSource
         {
-            public FbxNode node;
-            public float weight;
+            private FbxNode m_node;
+            public FbxNode node
+            {
+                get { return m_node; }
+                set { m_node = value; }
+            }
+
+            private float m_weight;
+            public float weight
+            {
+                get { return m_weight; }
+                set { m_weight = value; }
+            }
 
             public ExpConstraintSource(FbxNode node, float weight)
             {
-                this.node = node;
-                this.weight = weight;
+                this.m_node = node;
+                this.m_weight = weight;
             }
         }
 

Packages/com.unity.formats.fbx/Editor/Scripts/FbxExporterRepairMissingScripts.cs

@@ -40,25 +40,32 @@ private string[] AssetsToRepair{
             }
         }
 
-        public static string GetSourceCodeSearchID()
+        public static string SourceCodeSearchID
         {
-            var fbxPrefabObj = AssetDatabase.LoadMainAssetAtPath(FbxPrefabAutoUpdater.FindFbxPrefabAssetPath());
-            string searchID = null;
-            string guid;
+            get
+            {
+                var fbxPrefabObj = AssetDatabase.LoadMainAssetAtPath(FbxPrefabAutoUpdater.FindFbxPrefabAssetPath());
+                string searchID = null;
+                string guid;
 #if UNITY_2018_2_OR_NEWER
-            long fileId;
+                long fileId;
 #else
             int fileId;
 #endif
-            if(AssetDatabase.TryGetGUIDAndLocalFileIdentifier(fbxPrefabObj, out guid, out fileId))
-            {
-                searchID = string.Format(IdFormat, fileId, guid);
+                if (AssetDatabase.TryGetGUIDAndLocalFileIdentifier(fbxPrefabObj, out guid, out fileId))
+                {
+                    searchID = string.Format(IdFormat, fileId, guid);
+                }
+                return searchID;
             }
-            return searchID;
         }
 
-        public int GetAssetsToRepairCount(){
-            return AssetsToRepair.Length;
+        public int AssetsToRepairCount
+        {
+            get
+            {
+                return AssetsToRepair.Length;
+            }
         }
 
         public string[] GetAssetsToRepair(){
@@ -114,7 +121,7 @@ private static bool AssetNeedsRepair(string filePath)
 
         public bool ReplaceGUIDInTextAssets ()
         {
-            string sourceCodeSearchID = GetSourceCodeSearchID();
+            string sourceCodeSearchID = SourceCodeSearchID;
             if(string.IsNullOrEmpty(sourceCodeSearchID))
             {
                 return false;

Packages/com.unity.formats.fbx/Editor/Scripts/FbxPrefabAutoUpdater.cs

@@ -7,6 +7,18 @@
 
 namespace UnityEditor.Formats.Fbx.Exporter
 {
+    /// <summary>
+    /// Exception that denotes a likely programming error.
+    /// </summary>
+    [System.Serializable]
+    public class FbxPrefabException : System.Exception
+    {
+        public FbxPrefabException() { }
+        public FbxPrefabException(string message) : base(message) { }
+        public FbxPrefabException(string message, System.Exception inner) : base(message, inner) { }
+        protected FbxPrefabException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+    }
+
     /// <summary>
     /// This class handles updating prefabs that are linked to an FBX source file.
     ///
@@ -512,18 +524,6 @@ public static void Append<TKey1, TKey2, TValue>(ref Dictionary<TKey1, Dictionary
                 Append(thesubmap, key2, item);
             }
 
-            /// <summary>
-            /// Exception that denotes a likely programming error.
-            /// </summary>
-            [System.Serializable]
-            public class FbxPrefabException : System.Exception
-            {
-                public FbxPrefabException() { }
-                public FbxPrefabException(string message) : base(message) { }
-                public FbxPrefabException(string message, System.Exception inner) : base(message, inner) { }
-                protected FbxPrefabException(SerializationInfo info, StreamingContext context) : base(info, context) { }
-            }
-
             /// <summary>
             /// Representation of a hierarchy with components.
             ///

Packages/com.unity.formats.fbx/Editor/Scripts/FbxRotationCurve.cs

@@ -26,8 +26,18 @@ public AnimationCurve[] Curves
 
 
         protected struct Key {
-            public FbxTime time;
-            public FbxVector4 euler;
+            private FbxTime m_time;
+            public FbxTime time
+            {
+                get { return m_time; }
+                set { m_time = value; }
+            }
+            private FbxVector4 m_euler;
+            public FbxVector4 euler
+            {
+                get { return m_euler; }
+                set { m_euler = value; }
+            }
         }
 
         protected RotationCurve() { }
@@ -69,7 +79,7 @@ private Key [] ComputeKeys(UnityEngine.Quaternion restRotation, FbxNode node) {
                 var fbxFinalQuat = fbxPreRotationInverse * fbxFinalAnimation;
 
                 // Store the key so we can sort them later.
-                Key key;
+                Key key = new Key();
                 key.time = FbxTime.FromSecondDouble(seconds);
                 key.euler = ModelExporter.QuaternionToEuler (fbxFinalQuat);
                 keys[i++] = key;